650111 - Search does not find all questions marked as helpful

Status: VERIFIED FIXED

(support.mozilla.org :: Search, defect)

Description

[Rebecca Billings [:rbillings]]

Running a search query for the title of an unsolved question that has helpful replies does not always find results. 

1) Support-release: search for 'hunky dory'
expected: https://support-release.allizom.org/en-US/questions/775589
actual: none
2) search 'release the ball'
expected: https://support-release.allizom.org/en-US/questions/775567
actual: none

** Search for item such as 'plugin failure' DO return unsolved questions with helpful replies

Comment 1

[James Socol [:jsocol, :james]]

The index only thinks the question has 3 replies and no helpful replies, so it isn't turning up. Shyam or Jeremy, can you double check that search indexing is running correctly for support-release (a.k.a. support-stage-new on pm-app-sphinx01)?

Comment 2

[Shyam Mani [:fox2mike]]

So, first run gave me this :

[root@pm-app-sphinx01 ~]# su -s /bin/sh -c '/data/bin/sphinx-reindex support-stage-new' daemon
Sphinx 0.9.9-release (r2117)
Copyright (c) 2001-2009, Andrew Aksyonoff

using config file '/data/sphinx/support-stage-new/sphinx.conf'...
FATAL: failed to lock pid file '/data/sphinx/support-stage-new/bin/searchd.pid': Resource temporarily unavailable (searchd already running?)

[root@pm-app-sphinx01 ~]# ls -l /data/sphinx/support-stage-new/bin/searchd.pid
-rw------- 1 daemon daemon 5 Feb 21 00:20 /data/sphinx/support-stage-new/bin/searchd.pid

Which is kinda suspicious, so I dug some more. searchd was indeed running, so I stopped it and ran again :

[root@pm-app-sphinx01 ~]# su -s /bin/sh -c '/data/bin/sphinx-reindex support-stage-new' daemon
Sphinx 0.9.9-release (r2117)
Copyright (c) 2001-2009, Andrew Aksyonoff

using config file '/data/sphinx/support-stage-new/sphinx.conf'...
listening on all interfaces, port=3320
listening on 10.2.83.70:3385

Meh. No change. So I looked at sphinx.conf :

root@pm-app-sphinx01 ~]# ls -l /data/sphinx/support-stage-new/sphinx.conf
-rw-r--r-- 1 daemon root 13279 Feb 28 09:02 /data/sphinx/support-stage-new/sphinx.conf

Feb 28. More meh, so I ran the update script, which completed fine.

The update script has the following :

git fetch -q origin
git checkout -q origin/2.3.x

Is that correct? Considering kitsune on support-release has :

git fetch -q
git checkout -q origin/next

I'm assuming sphinx is outdated. If that's the case, can you file a bug with the right branches for the same and have that block this, and I'll fix it.

Comment 3

[James Socol [:jsocol, :james]]

Filed bug 651847. Thanks, Shyam!

Comment 4

[James Socol [:jsocol, :james]]

Rebecca, would you mind re-testing on support-release?

Comment 5

[Shyam Mani [:fox2mike]]

Rebecca, give it an hour or two before you test.

James, I also found lock files that have been in place for months...which isn't good (updates never happened) :

sphinx02 : rw-r--r--  1 daemon daemon     0 Mar  9 08:02 updating.lock
sphinx01 : rw-r--r--  1 daemon daemon     0 Feb 28 09:17 updating.lock

Both of these have been removed. I'll file a bug for us to monitor this file.

Comment 6

[Shyam Mani [:fox2mike]]

(In reply to comment #5)
> James, I also found lock files that have been in place for months...which isn't
> good (updates never happened) :
> 
> sphinx02 : rw-r--r--  1 daemon daemon     0 Mar  9 08:02 updating.lock
> sphinx01 : rw-r--r--  1 daemon daemon     0 Feb 28 09:17 updating.lock
> 
> Both of these have been removed. I'll file a bug for us to monitor this file.

Ran stuff manually by hand, looks good!

[root@pm-app-sphinx01 support-stage-new]# su -s /bin/sh -c '/data/bin/update-support-stage-new' daemon
/data/sphinx/support-stage-new/git /data/sphinx/support-stage-new
/data/sphinx/support-stage-new
[root@pm-app-sphinx01 support-stage-new]# su -s /bin/sh -c '/data/bin/sphinx-reindex support-stage-new' daemon
Sphinx 0.9.9-release (r2117)
Copyright (c) 2001-2009, Andrew Aksyonoff

using config file '/data/sphinx/support-stage-new/sphinx.conf'...
FATAL: failed to lock pid file '/data/sphinx/support-stage-new/bin/searchd.pid': Resource temporarily unavailable (searchd already running?)
Sphinx 0.9.9-release (r2117)
Copyright (c) 2001-2009, Andrew Aksyonoff

using config file '/data/sphinx/support-stage-new/sphinx.conf'...
indexing index 'questions'...
collected 79278 docs, 59.0 MB
collected 363271 attr values
sorted 0.4 Mvalues, 100.0% done
sorted 5.9 Mhits, 100.0% done
total 79278 docs, 58961247 bytes
total 23.797 sec, 2477640 bytes/sec, 3331.38 docs/sec
indexing index 'discussion_forums'...
collected 12025 docs, 4.1 MB
sorted 0.4 Mhits, 100.0% done
total 12025 docs, 4101281 bytes
total 1.274 sec, 3216799 bytes/sec, 9431.69 docs/sec
indexing index 'wiki_pages'...
collected 4748 docs, 15.8 MB
collected 32846 attr values
sorted 0.0 Mvalues, 100.0% done
sorted 2.2 Mhits, 100.0% done
total 4748 docs, 15813410 bytes
total 7.219 sec, 2190378 bytes/sec, 657.66 docs/sec
total 26 reads, 0.041 sec, 1917.5 kb/call avg, 1.5 msec/call avg
total 125 writes, 0.202 sec, 888.9 kb/call avg, 1.6 msec/call avg
rotating indices: succesfully sent SIGHUP to searchd (pid=18379).

Comment 7

[Rebecca Billings [:rbillings]]

Verified search results come back correctly now on support-release.