650153 - moz20-firefox-win32.cfg has bad buildid in it?

Status: RESOLVED WORKSFORME

(Release Engineering :: General, defect, P3)

Description

[Chris AtLee [:catlee]]

release="4.0" product="Firefox" platform="WINNT_x86-msvc" build_id="20110303194838^M" locales="af ak ar ast be bg bn-BD bn-IN br bs ca cs cy da de el en-GB en-US en-ZA eo es-AR es-CL es-ES es-MX et eu fa fi fr fy-NL ga-IE gd gl gu-IN he hi-IN hr hu hy-AM id is it ja kk kn ko ku lg lt lv mai mk ml mr nb-NO nl nn-NO nso or pa-IN pl pt-BR pt-PT rm ro ru si sk sl son sq sr sv-SE ta ta-LK te th tr uk zh-CN zh-TW zu" channel="betatest" 

Notice the "^M" in build_id. No idea if this is a problem or not.

Comment 1

[John Ford [:jhford] CET/CEST Berlin Time]

Chris, not sure from looking which exact config file this is.  Can we remove the ^M character and push back?

Comment 2

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: remove the ^M char

Comment 3

[John Ford [:jhford] CET/CEST Berlin Time]

$ find -type f -name "*.cfg" -exec grep ^M {} \;
" locales="af ak ar ast be bg bn-BD bn-IN br bs ca cs cy da de el en-GB en-US en-ZA eo es-AR es-CL es-ES es-MX et eu fa fi fr fy-NL ga-IE gd gl gu-IN he hi-IN hr hu hy-AM id is it ja kk kn ko ku lg lt lv mai mk ml mr nb-NO nl nn-NO nso or pa-IN pl pt-BR pt-PT rm ro ru si sk sl son sq sr sv-SE ta ta-LK te th tr uk zh-CN zh-TW zu" channel="betatest"
$ hg import --no-commit https://bug650153.bugzilla.mozilla.org/attachment.cgi?id=526837
applying https://bug650153.bugzilla.mozilla.org/attachment.cgi?id=526837
$ find -type f -name "*.cfg" -exec grep ^M {} \;
$

It looks like this was a typo

Comment 4

[John Ford [:jhford] CET/CEST Berlin Time]

http://hg.mozilla.org/build/tools/rev/ed75fb618462, nope, it was an automated entry for rc2.

Comment 5

[Chris AtLee [:catlee]]

I'm really interested to know how this could have happened

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

it looks like http://hg.mozilla.org/build/tools/rev/57683ba52375 landed after the last non-^M changeset and before the first ^M changeset of the verify configs.

Comment 7

[Chris Cooper [:coop] (he/him)]

jhford: does your patch just need a check-in?

Comment 8

[[e-mail] (:bhearsum)]

I hit something like this a few weeks ago, too:
http://hg.mozilla.org/users/bhearsum_mozilla.com/tools/raw-file/d7395ab966af/release/updates/moz20-firefox-win32.cfg

So it's not a completely isolated incident.

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

this hasn't been reported in a while.  If we figure out what's going on, lets open a bug.