Last Comment Bug 650157 - Push nsBuiltinDecoderReader::mDataOffset down to nsOggReader
: Push nsBuiltinDecoderReader::mDataOffset down to nsOggReader
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Audio/Video (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla6
Assigned To: Chris Pearce (:cpearce)
:
Mentors:
Depends on:
Blocks: 566779
  Show dependency treegraph
 
Reported: 2011-04-14 16:35 PDT by Chris Pearce (:cpearce)
Modified: 2011-04-14 18:39 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (9.46 KB, patch)
2011-04-14 16:37 PDT, Chris Pearce (:cpearce)
no flags Details | Diff | Review

Description Chris Pearce (:cpearce) 2011-04-14 16:35:53 PDT
Only nsOggReader uses nsBuiltinDecoderReader::mDataOffset, so we should push it down into nsOggReader.

I've spun this off from bug 566779. I have a reviewed patch in that bug that I want to land now so I can base other work on top of it.
Comment 1 Chris Pearce (:cpearce) 2011-04-14 16:37:46 PDT
Created attachment 526152 [details] [diff] [review]
Patch

Carrying forward r=doublec from review in bug 566779.
Comment 2 Chris Pearce (:cpearce) 2011-04-14 18:39:40 PDT
http://hg.mozilla.org/mozilla-central/rev/24505fa656f3

Note You need to log in before you can comment on or make changes to this bug.