http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1302796344.1302799845.1886.gz xpcom/glue/arm.cpp:165: warning: 'bool<unnamed>::check_edsp()' defined but not used xpcom/glue/arm.cpp:171: warning: 'bool<unnamed>::check_armv6()' defined but not used xpcom/glue/arm.cpp:177: warning: 'bool<unnamed>::check_neon()' defined but not used Looks like these functions are defined always (or at least "on linux x86_64 debug builds"), but their callers are #ifdef'd like e.g. > 192 #if !defined(MOZILLA_PRESUME_ARMV6) > 193 bool armv6_enabled = check_armv6(); > 194 #endif Could we add the same #if conditions around these function definitions, to avoid building them when we don't need them, and to avoid spamming compile warnings?
actually, the more important ifdef around these functions' usages is probably: > #if defined(MOZILLA_ARM_HAVE_CPUID_DETECTION)
Created attachment 526173 [details] [diff] [review] #ifdef out unused functions I refactored the #ifdef's to be consistent about when things are defined vs. called, and also updated the indentation (which was inconsistent) and added comments for the closing #endifs which were far from their corresponding #ifs.
6 years ago