Closed Bug 650227 Opened 9 years ago Closed 9 years ago

Adapt comm-central build configuration for building Miramar builds off of comm-central and mozilla-aurora

Categories

(MailNews Core :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 5.0b1

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

I want to get Miramar builds moved onto the version of gecko that we're actually going to be shipping from.

I believe that with some build config changes we can do this without affecting SeaMonkey builds (and we can remove the gecko 2.0 specific stuff once SeaMonkey branches).

I'll be doing a patch for this in a bit.
Attached patch The fixSplinter Review
This fixes it for Thunderbird only, but SeaMonkey can pick it up when ready (if needed).

I'll take the review of whoever gets there first as I'm hoping to land this today if possible.
Attachment #526220 - Flags: review?(kairo)
Attachment #526220 - Flags: review?(gozer)
Attachment #526220 - Flags: review?(bugspam.Callek)
Attachment #526220 - Flags: review?(gozer) → review+
Attachment #526220 - Flags: review?(kairo)
Attachment #526220 - Flags: review?(bugspam.Callek)
Checked in: http://hg.mozilla.org/comm-central/rev/109f6f7db7fb
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Target Milestone: --- → Thunderbird 3.3a4
Version: unspecified → Trunk
Comment on attachment 526220 [details] [diff] [review]
The fix

> ifdef MOZILLA_2_0_BRANCH
> THUNDERBIRD_VERSION := $(shell cat $(topsrcdir)/mail/config/version-20.txt)

Nit: you should remove this obsoleted lone too. (3 times)

> SEAMONKEY_VERSION := $(shell cat $(topsrcdir)/suite/config/version-20.txt)
>+elif defined(MOZILLA_5_0_BRANCH)
>+THUNDERBIRD_VERSION := $(shell cat $(topsrcdir)/mail/config/version-50.txt)
(In reply to comment #3)
> Comment on attachment 526220 [details] [diff] [review]
> The fix
> 
> > ifdef MOZILLA_2_0_BRANCH
> > THUNDERBIRD_VERSION := $(shell cat $(topsrcdir)/mail/config/version-20.txt)
> 
> Nit: you should remove this obsoleted lone too. (3 times)

No point. It doesn't hurt anything and we can just do it all in one block when we remove MOZILLA_2_0_BRANCH.
Version: Trunk → unspecified
This seem to have regressed Lightning Bug 651196.
You need to log in before you can comment on or make changes to this bug.