650313 - [traceback] Error on /en-US/m/yourlocation: NoReverseMatch for 'mobile.boost1_complete'

Status: VERIFIED FIXED

(Websites :: spark.mozilla.org, defect)

Description

[Franck Lecollinet]

Among the code changes in 1.1 for the new Boost 1 confirm feature and desktop Boost, I forgot to remove one reference to an unused url. 

Fortunately it's not affecting too many users because it involves hitting the back button after selecting a city manually (on mobile). It's a quite infrequent scenario.


Here is the traceback received from the production server:

Traceback (most recent call last):

 File "/data/www/django/spark.mozilla.org/spark_site/vendor/src/django/django/core/handlers/base.py", line 100, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/www/django/spark.mozilla.org/spark_site/apps/spark/decorators.py", line 83, in _wrapped_view
   return view_fn(request, *args, **kwargs)

 File "/data/www/django/spark.mozilla.org/spark_site/apps/spark/decorators.py", line 146, in wrapper
   response = f(*args, **kw)

 File "/data/www/django/spark.mozilla.org/spark_site/apps/mobile/views.py", line 157, in geolocation_fallback
   return HttpResponseRedirect(reverse('mobile.boost1_complete'))

 File "/data/www/django/spark.mozilla.org/spark_site/apps/spark/urlresolvers.py", line 52, in reverse
   url = django_reverse(viewname, urlconf, args, kwargs, prefix)

 File "/data/www/django/spark.mozilla.org/spark_site/vendor/src/django/django/core/urlresolvers.py", line 351, in reverse
   *args, **kwargs)))

 File "/data/www/django/spark.mozilla.org/spark_site/vendor/src/django/django/core/urlresolvers.py", line 297, in reverse
   "arguments '%s' not found." % (lookup_view_s, args, kwargs))

NoReverseMatch: Reverse for 'mobile.boost1_complete' with arguments '()' and keyword arguments '{}' not found.

Comment 2

[Franck Lecollinet]

Fixed in commit:
https://github.com/mozilla/spark/commit/61776e0c6e2c206236631b4fc99151e50525eb8c

This can be tested by completing Boost step 1 and then try to access /en-US/m/yourlocation

On production this currently throws an error. The fix will now redirect to Boost step 2 if the first one has already been completed.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

The tracebacks subsided since we pushed ~10am, PDT.

Verified FIXED.