650316 - Disable Morkreader in Fennec

Status: RESOLVED DUPLICATE of bug 578268

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

We have a tiny library called morkreader that is used for importing history from old versions of Firefox/Mozilla.  This is never used on Fennec.  This patch disables it and the code that uses it.

I did this as an experiment in size reduction, but the reduction in our compressed APK size is only 7 KB.  I'm not sure this is worth checking in, unless we make it part of a much larger effort to identify and disable more dead code.

Comment 2

[Makoto Kato [:m_kato]]

You should consider unit test (/toolkit/components/places/tests/unit/test_history_import.js).  This test needs mork reader, so you should be turn off this test if MOZ_MORKREADER isn't set.

Comment 3

[Marco Bonardo [:mak]]

I think this bug will be useless once bug 578268 lands since the reader will be opt-in.

Comment 4

[Matt Brubeck (:mbrubeck)]

Thanks Makoto - sorry for duplicating your work.  And thanks for the pointer, Marco - this is good news.