650363 - Move locale fudging out of webroot/.htaccess

Status: VERIFIED FIXED

(support.mozilla.org :: Code Quality, task, P3)

Description

[James Socol [:jsocol, :james]]

Toward the bottom of .htaccess we've got this section:

# Redirect locales that point to one locale in SUMO.
# Kitsune does this by itself, mostly.
# Not sure about this guy: may need to special-case it in the LocaleURLMiddleware.
RewriteRule ^n[bn]\-NO/(.+)$           /no/$1 [L,R]
# Just need to move sr-CYRL above sr-LATN to get this.
RewriteRule ^sr/(.+)$           /sr-CYRL/$1 [L,R]

I don't know how accurate my comments are. Maybe adding some kind of "given this non-supported locale, go here" map and using that in LocaleURLMiddleware (we could also use it to handle other not-yet-supported but legit locales). Hopefully I'm right about Serbian.

Comment 1

[James Socol [:jsocol, :james]]

https://github.com/jsocol/kitsune/compare/b2fda76f6^...50f3ea9e

To test, verify that /nb-NO/home and /nn-NO/home still go to /no/home, and that /sr/home still goes to /sr-CYRL/home.

Comment 2

[Rebecca Billings [:rbillings]]

All redirect as expected except the following:

/nb-NO/home >> https://support.allizom.org/nb-NO/home

Comment 3

[James Socol [:jsocol, :james]]

Oops, I checked settings.py and that's actually correct--nb-NO is in the supported locales list.

Comment 4

[Rebecca Billings [:rbillings]]

Verified, closed.