[READY] test_webgl_conformance_test_suite.html needs to be explicit about its timeout requirements

RESOLVED FIXED in mozilla32

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla32
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: webgl-internal)

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

7 years ago
Created attachment 526520 [details] [diff] [review]
Patch (v1)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #526520 - Flags: review?(bjacob)
What does requestFlakyTimeout do?
(Assignee)

Comment 3

7 years ago
(In reply to comment #2)
> What does requestFlakyTimeout do?

See bug 649012.  It enables the test to use setTimeout(f, t) where t>0 in exceptional cases (such as this one).

These types of timeouts in tests have always been a source of intermittent oranges for us, so I'm planning to disable using them in bug 649012.
Attachment #526520 - Flags: review?(bjacob) → review+
(Assignee)

Updated

7 years ago
Summary: test_webgl_conformance_test_suite.html needs to be explicit about its timeout requirements → [READY] test_webgl_conformance_test_suite.html needs to be explicit about its timeout requirements

Comment 4

7 years ago
Ehsan, are you still planning to land this?
(Assignee)

Comment 5

7 years ago
Yes, but all of the dependencies of bug 649012 should get fixed first, and I don't have time to do that right now...
Whiteboard: webgl-internal
This probably has severe bitrot. Is this worth saving?
Flags: needinfo?(ehsan)
(Assignee)

Comment 7

5 years ago
Only if somebody starts to resurrect my work in bug 649012.  This is one of the many dependencies there.
Flags: needinfo?(ehsan)
https://hg.mozilla.org/mozilla-central/rev/7e7281a034bb
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.