Closed Bug 650580 Opened 9 years ago Closed 6 years ago

[READY] Test for bug 624047 needs to be explicit about its setTimeout requirements

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED INVALID

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

No description provided.
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #526551 - Flags: review?(jonas)
Also, we could think of adding some test API that can force call of the code that is normally invoked by the internal storage timer and get rid of setTimeout from the test at all then.
Summary: Test for bug 624047 needs to be explicit about its setTimeout requirements → [READY] Test for bug 624047 needs to be explicit about its setTimeout requirements
(In reply to comment #2)
> Also, we could think of adding some test API that can force call of the code
> that is normally invoked by the internal storage timer and get rid of
> setTimeout from the test at all then.

Great.  Is this something that you can work on, please?
(In reply to comment #3)
> Great.  Is this something that you can work on, please?

Yes, but not sure how soon I can get to this.  It's a large change and needs good testing and thinking if that is going to test what needs to be tested.  But yes, I can do that.
(In reply to comment #4)
> (In reply to comment #3)
> > Great.  Is this something that you can work on, please?
> 
> Yes, but not sure how soon I can get to this.  It's a large change and needs
> good testing and thinking if that is going to test what needs to be tested. 
> But yes, I can do that.

Great.  I guess we can proceed with this patch for now, but I filed bug 653593 to track the future improvements here.
Bug 600307 removed this test.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
Oops, I landed an empty patch for this by mistake: https://hg.mozilla.org/integration/mozilla-inbound/rev/5992fd8e82d0
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.