650580 - [READY] Test for bug 624047 needs to be explicit about its setTimeout requirements

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, defect)

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Honza Bambas (:mayhemer)]

Also, we could think of adding some test API that can force call of the code that is normally invoked by the internal storage timer and get rid of setTimeout from the test at all then.

Comment 3

[(no longer active)]

(In reply to comment #2)
> Also, we could think of adding some test API that can force call of the code
> that is normally invoked by the internal storage timer and get rid of
> setTimeout from the test at all then.

Great.  Is this something that you can work on, please?

Comment 4

[Honza Bambas (:mayhemer)]

(In reply to comment #3)
> Great.  Is this something that you can work on, please?

Yes, but not sure how soon I can get to this.  It's a large change and needs good testing and thinking if that is going to test what needs to be tested.  But yes, I can do that.

Comment 5

[(no longer active)]

(In reply to comment #4)
> (In reply to comment #3)
> > Great.  Is this something that you can work on, please?
> 
> Yes, but not sure how soon I can get to this.  It's a large change and needs
> good testing and thinking if that is going to test what needs to be tested. 
> But yes, I can do that.

Great.  I guess we can proceed with this patch for now, but I filed bug 653593 to track the future improvements here.

Comment 6

[(no longer active)]

Bug 600307 removed this test.

Comment 7

[(no longer active)]

Oops, I landed an empty patch for this by mistake: https://hg.mozilla.org/integration/mozilla-inbound/rev/5992fd8e82d0

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5992fd8e82d0