SVN history links on HTTP status error pages link to prefetch.php history

RESOLVED WORKSFORME

Status

www.mozilla.org
Pages & Content
RESOLVED WORKSFORME
7 years ago
5 years ago

People

(Reporter: tanner, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 years ago
From (ironically enough) the 404 page it shows "Page history" which produces a 404. Is it supposed to go to prefetch.php in viewvc, or another page?

Updated

7 years ago
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 619842
I noticed this in the process of fixing bug 619842, but I don't think it is quite the same bug.

While currently affected by bug 619842, this bug is more about the question of what the history links on 404 (and other status) pages should be. Since they are generated as a result of running through prefetch.php, that's the history link that gets shown. However, it might be better to link it somewhere else—or nowhere at all.

Thus, I'm reopening this as a separate bug from bug 619842.
Status: RESOLVED → REOPENED
Depends on: 619842
Resolution: DUPLICATE → ---
Summary: [404] Link to http://viewvc.svn.mozilla.org/vc/projects/mozilla.org/trunk/%2Fincludes%2Fprefetch.php?view=log → SVN history links on HTTP status error pages link to prefetch.php history
Status: REOPENED → NEW
fwiw, clicking on the Last modified on ... link in:

http://www.mozilla.org/projects/security/secgrouplist.html

throws a 404 error.

Is this a new bug?

Comment 4

7 years ago
Gordon, any idea what may have happened here?  I cc'ed James in case this was merge related.
Yeah, it looks like it's trying to do some magic to figure out the file to show. We did some magic to make the merge work, and the magic is conflicting. This site really isn't a wiki anyway, and we are moving away from that, aren't we? All of those kind of links are probably broken and I'd have to look into the magic to see if it's fixable.

Comment 6

7 years ago
The site isn't a wiki, but we still need to make it easier for people to get involved with contributing to all of our sites.  I think links to how to edit pages and where to find repositories should be standard across all of our sites.
(In reply to David Boswell from comment #4)
> Gordon, any idea what may have happened here?  I cc'ed James in case this
> was merge related.

As James said, this is indeed merge related. All of the .org pages are now created by this file:
http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/includes/org-handler.php

Our footer is trying to link to that file, but it assumes that it's in projects/mozilla.org/, so it 404s.

Not sure how to fix it, but it would probably be best to open a separate bug. Assuming we do get the merge-related bug fixed, this current bug will probably crop up again. (Or maybe it won't, because 404 errors are now processed by the .com side of things, which doesn't have this link anywhere.)

Comment 8

7 years ago
Gordon, thanks for taking a look at this.  Are you interested in taking a pass at creating a patch for this?
Depends on: 694827
(In reply to David Boswell from comment #8)
> Gordon, thanks for taking a look at this.  Are you interested in taking a
> pass at creating a patch for this?

I'm not sure I'll have the time any time soon to do that, so don't wait on me. I may at some point in the future, if it's not too high a priority, though.

Be aware that Gerv filed bug 694827 for this issue, so discussion should continue there. (The current bug will likely still stand once the merge fallout bug has been fixed.)
(Assignee)

Updated

6 years ago
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
The current 404 page doesn't have a Page history link.
Status: NEW → RESOLVED
Last Resolved: 7 years ago5 years ago
Component: General → Pages & Content
OS: Linux → All
Hardware: x86 → All
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.