650670 - f1 should Include currently selected text in message body

Status: RESOLVED FIXED

(Mozilla Labs :: F1, defect)

Description

[eyal gruss]

f1 should Include currently selected text in message body. this is similar to the request in Bug 195814 for seaMonkey

Comment 1

[Bryan Clark (DevTools PM) [:clarkbw]]

We don't have any plans yet to implement this and we're tracking this request on uservoice right now.  Thanks for the suggestion!

http://feedback.mozillalabs.com/forums/107731-mozilla-f1/suggestions/1254053-add-highlighted-text-to-message-body?ref=title

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/fx-share-addon/pull/4

Pointer to Github pull-request

Comment 4

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to Mark Hammond (:markh) from comment #3)
> Created attachment 557429 [details]
> Pointer to Github pull request:
> https://github.com/mozilla/fx-share-addon/pull/4
> 
> Pointer to Github pull-request

Just want to confirm what I think is the correct behavior here.

1) A user selects some text on the page, opens the share panel
2) The selected text is then copied into the message panel for all share accounts (i.e. if you switch from facebook to twitter this selection message remains in the message area)
3) The copied text is selected/highlighted inside F1 panel such that a single delete would remove it (assumes the message is focused on open)

Comment 5

[Stormy Peters]

(In reply to Bryan Clark [:clarkbw] from comment #4)
> (In reply to Mark Hammond (:markh) from comment #3)
> > Created attachment 557429 [details]
> > Pointer to Github pull request:
> > https://github.com/mozilla/fx-share-addon/pull/4
> > 
> > Pointer to Github pull-request
> 
> Just want to confirm what I think is the correct behavior here.
> 
> 1) A user selects some text on the page, opens the share panel
> 2) The selected text is then copied into the message panel for all share
> accounts (i.e. if you switch from facebook to twitter this selection message
> remains in the message area)
> 3) The copied text is selected/highlighted inside F1 panel such that a
> single delete would remove it (assumes the message is focused on open)

That sounds exactly like I'd expect it to behave.

bit.ly and Evernote do similar things if we want to check out what others are doing.

Comment 6

[Mark Hammond [:markh] [:mhammond]]

Sounds good to me.  That pull request should do everything Bryan mentioned exception point 3 - the text isn't selected in the message area.  I'll make a new patch with this included.

Comment 7

[Mark Hammond [:markh] [:mhammond]]

Pushed the change so the text in that field is selected.  Note this change leverages the patch in bug 650672, so marking this bug as depending on that one.

Comment 8

[Shane Caraveo (:mixedpuppy)]

Attachment: Pointer to pull request

Comment 9

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 557429 [details]
Pointer to Github pull request: https://github.com/mozilla/fx-share-addon/pull/4

I've updated the pull request after merging develop which reduces this request down to the changes directly related to this bug.  I will review the new pull request I created.

Comment 10

[Shane Caraveo (:mixedpuppy)]

pushed https://github.com/mozilla/fx-share-addon/commit/207e437c827173096da40f9edf5ab863385952b0