65070 - paste into a textarea results in gibberish

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Colin Blake]

Attempting to paste text into a textarea results in gibberish being inserted.
Pasting the other way, into say a DECterm, works but a LF is always appended.

This worked fine on M18, but is broken in M0.6 and M0.7.

Comment 1

[Colin Blake]

In case it means something to someone, I'll attach the output I receive from
nsClipboard.cpp with DEBUG_CLIPBOARD defined.

Comment 2

[Colin Blake]

Attachment: DEBUG_CLIPBOARD output

Comment 3

[Colin Blake]

In widget/src/gtk/nsClipboard.cpp, if I change the order of the calls in the
following code:

    r = DoRealConvert(gdk_atom_intern("UTF8_STRING", FALSE), aSelectionAtom);
    if (r) return r;
    r = DoRealConvert(gdk_atom_intern("COMPOUND_TEXT", FALSE), aSelectionAtom);
    if (r) return r;
    r = DoRealConvert(GDK_SELECTION_TYPE_STRING, aSelectionAtom);
    if (r) return r;

so that COMPOUND_TEXT is first, then pasting works again. Unfortunately I don't
know enough of GTK and X to know what this is. Could it be that UTF8_STRING
requires X11R6 (OpenVMS is only R5)?

Comment 4

[Colin Blake]

When DoRealConvert is called with UTF8_STRING, I see the message:

  error retrieving selection: length was -1

on the console. But in DoRealConvert mSelectionData.length is a positive integer 
and so DoRealConvert returns as if everything is well and good.

Comment 5

[Colin Blake]

Attachment: proposed fix

Comment 6

[Colin Blake]

DoRealConvert expects mSelectionData to be greater than 0 if the conversion was
successful, but in SelectionReceiver we just return if the conversion failed.
The patch I just attached makes sure that mSelectionData is set to something
negative in the event of no conversion.

Looking for a review and super-review. Pav and Chris?

Comment 7

[Stuart Parmenter]

r=pavlov

Comment 8

[sairuh (rarely reading bugmail)]

sorry, i don't have access to vms...

Comment 9

[Christopher Blizzard (:blizzard)]

r=blizzard

Comment 10

[Colin Blake]

Checked in.
widget/src/gtk/nsClipboard.cpp rev 1.89

Comment 11

[sairuh (rarely reading bugmail)]

->tpreston for copy/paste [dunno if she has access to vms, tho'].