The default bug view has changed. See this FAQ.

Fix xptcall on OpenBSD/powerpc

RESOLVED FIXED in mozilla8

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: gaston, Assigned: gaston)

Tracking

unspecified
mozilla8
All
OpenBSD
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 526686 [details] [diff] [review]
Fix xptcall on OpenBSD/powerpc

As of now mozilla segfaults on OpenBSD/macppc if the attached patch is not present. We're shipping it with thunderbird/seamonkey/firefox* ports. it makes the xptc{invoke,stubs}_asm_ppc_openbsd.s files use c++-style for comments, and sets AS to CC, as done for linux/ppc*.

Don't ask me to comment on why/how/where/when this patch came around... i have no idea.
(Assignee)

Updated

6 years ago
Blocks: 650665
(Assignee)

Updated

6 years ago
Attachment #526686 - Flags: review?(benjamin)
Assignee: nobody → landry
Attachment #526686 - Flags: review?(benjamin) → review?(timeless)
(Assignee)

Comment 1

6 years ago
Oh, and this patch fixes the packaging error i was seeing in https://bugzilla.mozilla.org/show_bug.cgi?id=670719#c19. And it allows mozilla-central to run fine on openbsd/macppc, (with a bunch of other patches..) here's a proof : http://rhaalovely.net/~landry/stuff/ffx-8.0a1-openbsd-macppc.png (built on my ibook g4, running on my mac mini)

and the full build logs here : http://buildbot.rhaalovely.net/builders/mozilla-central-macppc/builds/46

Since this is not part of the regular mozilla builds and that patch can't break other parts of the tree, could this get commited before the next m-c->m-a shift ? That'll be one less patch to maintain for me...
(Assignee)

Updated

6 years ago
Attachment #526686 - Flags: review?(timeless) → review?(benjamin)
Attachment #526686 - Flags: review?(benjamin) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/f8a0d02f1257
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.