650749 - Fix xptcall on OpenBSD/powerpc

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Landry Breuil (:gaston)]

Attachment: Fix xptcall on OpenBSD/powerpc

As of now mozilla segfaults on OpenBSD/macppc if the attached patch is not present. We're shipping it with thunderbird/seamonkey/firefox* ports. it makes the xptc{invoke,stubs}_asm_ppc_openbsd.s files use c++-style for comments, and sets AS to CC, as done for linux/ppc*.

Don't ask me to comment on why/how/where/when this patch came around... i have no idea.

Comment 1

[Landry Breuil (:gaston)]

Oh, and this patch fixes the packaging error i was seeing in https://bugzilla.mozilla.org/show_bug.cgi?id=670719#c19. And it allows mozilla-central to run fine on openbsd/macppc, (with a bunch of other patches..) here's a proof : http://rhaalovely.net/~landry/stuff/ffx-8.0a1-openbsd-macppc.png (built on my ibook g4, running on my mac mini)

and the full build logs here : http://buildbot.rhaalovely.net/builders/mozilla-central-macppc/builds/46

Since this is not part of the regular mozilla builds and that patch can't break other parts of the tree, could this get commited before the next m-c->m-a shift ? That'll be one less patch to maintain for me...

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/f8a0d02f1257