75.89 KB, patch
|Details | Diff | Splinter Review|
All of the sample*.html files in wallet contain hardcoded font names. This is totally unnecessary and makes thing annoying for doing translations. Since these files are just straight HTML, they do not need fonts hardcoded. I will attach a diff.
Created attachment 22363 [details] [diff] [review] Removing font face from interview.html and sample*.html
r=morse assigning to mkaply so he can champion this and get it checked in.
My eyes glazed over -- wouldn't a style sheet solution be easier to read, maintain, modify, etc. -- as well as being more moderne? email@example.com to make progress, but please keep the bug open and consider using CSS. /be
I'm sending this over to wallet with brendan's last comment. These HTML files are really ugly and would be much better if they used CSS. Wallet folk can make a decision as to whether or not they want to keep the defect. Personally I think it should be closed. I was simply removing the hardcoded font names to make things easier to translate.
morse: are the html files used anymore? If not, could we remove them?
They are used in the debug menu.
I just removed all these files from the build.