650817 - Search engines list misinterprets tap and pan

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Andreea Pod]

Mozilla /5.0 (Android;Linux armv7l;rv:2.1) Gecko/20110317 Firefox/4.0b13pre Fennec /4.0
Device: LG Optimus 2X

Steps to reproduce:
1. Open fennec
2. Go to http://mycroft.mozdev.org/search-engines.html
3. Add more then 10 search engines from that page
3. Tap on the url bar
5. Tap on the search button

Scenario 1:
6. Pan the list to get to the last search engine

Expected results:
The list should pan without selecting any search engine.

Actual results:
When taping and panning the search engine that was tapped is accessed and loaded in the browser. Please see this video: http://www.youtube.com/user/qaioana#p/a/u/0/Poch7CwJMmo

Scenario 2:
6. Tap outside the search engines list (at the bottom of the screen)

Expected results:
The list should close and you should be in the awesome screen.

Actual results:
Taping outside is selecting the link that is under the list and the page is loaded.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

The patch does not used the button onclick listener but TapSingle to ensure the click is not fired if a pan has happened.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mozilla-central/rev/9f3466cf2163

Comment 3

[Andreea Pod]

The second scenario is still reproducible

Scenario 2:
6. Tap outside the search engines list (at the bottom of the screen)

Expected results:
The list should close and you should be in the awesome screen.

Actual results:
Taping outside is selecting the link that is under the list and the page is
loaded.

You can see this also in the video: http://www.youtube.com/user/qaioana#p/a/u/0/Poch7CwJMmo

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

After reading the steps to reproduce and tried on desktop, I think this is the behavior we want, the popup is closed on a mousedown by design.

Comment 5

[Ioana Chiorean]

TC https://litmus.mozilla.org/single_result.cgi?id=427329 fails due to this bug.

Comment 6

[Anna (Waverley)]

VERIFIED FIXED on:

Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110523 Firefox/6.0a1 Fennec/6.0a1 

Device: HTC Desire Z (Android 2.2)