Closed
Bug 650947
Opened 13 years ago
Closed 13 years ago
Make sure that NoScript doesn't break startup test page
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jwkbugzilla, Assigned: anodelman)
References
Details
Attachments
(1 file)
1.11 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
Currently NoScript will prevent startup_test.html from working, it won't allow JavaScript to run there. So the tests "crash". Adding the following pref works around this issue:
> noscript.default: 'file:// about:blank about:credits addons.mozilla.org mozilla.net flashgot.net google.com gstatic.com googleapis.com securecode.com informaction.com yahoo.com yimg.com yahooapis.com maone.net noscript.net hotmail.com msn.com passport.com passport.net passportimages.com live.com js.wlxrs.com'
This is the default value of this pref, only with file:// added. I left the complete default whitelist there because it might have an impact on performance.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → anodelman
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #526848 -
Flags: review?(jmaher)
Comment 2•13 years ago
|
||
Comment on attachment 526848 [details] [diff] [review] [checked in]add file:// to noscript default white list two things to think about which can be ignored or dealt with in another bug: 1) is there a way to append or pre-pend a value to this pref? I can see the defaults changing in the future and we need to play catch up in the talos code. 2) for remote testing on mobile devices this won't work as we test with http:// instead of file. Solving the #1 problem would solve it for #2 as well. r+ since I don't think the noscript.default pref will change [significantly] in the short term.
Attachment #526848 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Comment on attachment 526848 [details] [diff] [review] [checked in]add file:// to noscript default white list changeset: 234:4cee81b4c29b
Attachment #526848 -
Attachment description: add file:// to noscript default white list → [checked in]add file:// to noscript default white list
Assignee | ||
Comment 4•13 years ago
|
||
Deployed.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•