Link to valid signature doesn't find it because of small/short range_value

VERIFIED FIXED in 1.7.8

Status

--
major
VERIFIED FIXED
8 years ago
5 years ago

People

(Reporter: stephend, Assigned: brandon)

Tracking

Trunk
1.7.8
Bug Flags:
in-litmus ?

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(3 attachments)

(Reporter)

Comment 1

8 years ago
Created attachment 526879 [details]
A ton more 404s; this time Fennec -- same issue w/date ranges?
(Assignee)

Updated

8 years ago
Assignee: nobody → bsavage
(Assignee)

Comment 2

8 years ago
It looks like this specific report is time bound - that is, top changers over a given period. When the user clicks through, they receive a report of the signatures provided over the last X days (3, 7, 14, or 28). I was only able to reproduce this with downward-trending signatures, indicating to me that there may not have been any crashes processed with the given signature in the time we are calling for.

Do we want to override the time boundary in producing the report and default to 2 weeks, as we do for most other reports, or do we want to stick with what we're currently doing, even though it's possible the user could be faced with no data (because a signature is trending down due to no crashes in that period)?

Comment 3

8 years ago
Here's how I think this should work.

If no crashes are found in the period, give the user a message like 
"No crashes with that signature were found in the last n days.  Try searching a different time period:
x days y days z days or <link>advanced search</link> for a custom time period."

How does that sound stephend?
Target Milestone: 1.7.7 → 1.7.8
(Reporter)

Comment 4

8 years ago
(In reply to comment #3)

> How does that sound stephend?

Sounds awesome to me!
(Assignee)

Comment 5

8 years ago
Created attachment 528123 [details] [diff] [review]
Improving report view

This patch does two things: first, Socorro no longer returns a 404 when it doesn't find any reports in the range given. Second, it presents the option to change the date range within the report list view, and automatically adjusts to the date range the user gives.
Attachment #528123 - Flags: review?(rhelmer)
Attachment #528123 - Flags: feedback?(laura)
Comment on attachment 528123 [details] [diff] [review]
Improving report view

>Index: views/report/do_list.php
>===================================================================
>--- views/report/do_list.php	(revision 3091)
>+++ views/report/do_list.php	(working copy)
>@@ -32,11 +32,38 @@
>             - Crash Reports for <?php out::H($display_signature) ?>
>         <?php } ?>	    
> 	</h2>
>+	<div>
>+	    <ul class="options">
>+<?php
>+
>+$options = array(
>+	'hours' => array('6' => '6 hours', '12' => '12 hours', '24' => '24 hours', '48' => '48 hours'),
>+	'days' => array('3' => '3 days', '7' => '7 days', '14' => '14 days', '28' => '28 days'),
>+	'weeks' => array('1' => '1 week', '2' => '2 weeks', '3' => '3 weeks', '4' => '4 weeks'),
>+);
>+
>+$type = $params['range_unit'];
>+$current = $params['range_value'];
>+$urlParams = $params;
>+
>+foreach($options[$type] as $k => $human) {

$human seems like an odd choice for variable name; other than that seems fine :)
Attachment #528123 - Flags: review?(rhelmer) → review+
(Assignee)

Comment 7

8 years ago
Fixed in revision 3108 with a slightly modified patch based on the patch approved (fixed the odd variable name choice).
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Reporter)

Comment 9

8 years ago
Created attachment 530138 [details]
Post-fix screenshot
Component: Socorro → General
Product: Webtools → Socorro

Updated

5 years ago
Attachment #528123 - Flags: feedback?(laura)
You need to log in before you can comment on or make changes to this bug.