650993 - Link to valid signature doesn't find it because of small/short range_value

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

https://crash-stats.stage.mozilla.com/report/list?range_value=7&range_unit=days&signature=F_181486744____________________________________________&version=Firefox%3A3.6.3
error code: 404 (not found), linked from page(s):
	https://crash-stats.stage.mozilla.com/products/Firefox/versions/3.6.3/topchangers
	https://crash-stats.stage.mozilla.com/products/Firefox/versions/3.6.3/topchangers?duration=7


FWIW, https://crash-stats.stage.mozilla.com/report/list?range_value=14&range_unit=days&signature=F_181486744____________________________________________&version=Firefox%3A3.6.3

finds it -- increased range_value to 14, from 7.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: A ton more 404s; this time Fennec -- same issue w/date ranges?

Comment 2

[Brandon Savage [:brandon]]

It looks like this specific report is time bound - that is, top changers over a given period. When the user clicks through, they receive a report of the signatures provided over the last X days (3, 7, 14, or 28). I was only able to reproduce this with downward-trending signatures, indicating to me that there may not have been any crashes processed with the given signature in the time we are calling for.

Do we want to override the time boundary in producing the report and default to 2 weeks, as we do for most other reports, or do we want to stick with what we're currently doing, even though it's possible the user could be faced with no data (because a signature is trending down due to no crashes in that period)?

Comment 3

[Laura Thomson :laura]

Here's how I think this should work.

If no crashes are found in the period, give the user a message like 
"No crashes with that signature were found in the last n days.  Try searching a different time period:
x days y days z days or <link>advanced search</link> for a custom time period."

How does that sound stephend?

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #3)

> How does that sound stephend?

Sounds awesome to me!

Comment 5

[Brandon Savage [:brandon]]

Attachment: Improving report view

This patch does two things: first, Socorro no longer returns a 404 when it doesn't find any reports in the range given. Second, it presents the option to change the date range within the report list view, and automatically adjusts to the date range the user gives.

Comment 6

[Robert Helmer [:rhelmer]]

Comment on attachment 528123 [details] [diff] [review]
Improving report view

>Index: views/report/do_list.php
>===================================================================
>--- views/report/do_list.php	(revision 3091)
>+++ views/report/do_list.php	(working copy)
>@@ -32,11 +32,38 @@
>             - Crash Reports for <?php out::H($display_signature) ?>
>         <?php } ?>	    
> 	</h2>
>+	<div>
>+	    <ul class="options">
>+<?php
>+
>+$options = array(
>+	'hours' => array('6' => '6 hours', '12' => '12 hours', '24' => '24 hours', '48' => '48 hours'),
>+	'days' => array('3' => '3 days', '7' => '7 days', '14' => '14 days', '28' => '28 days'),
>+	'weeks' => array('1' => '1 week', '2' => '2 weeks', '3' => '3 weeks', '4' => '4 weeks'),
>+);
>+
>+$type = $params['range_unit'];
>+$current = $params['range_value'];
>+$urlParams = $params;
>+
>+foreach($options[$type] as $k => $human) {

$human seems like an odd choice for variable name; other than that seems fine :)

Comment 7

[Brandon Savage [:brandon]]

Fixed in revision 3108 with a slightly modified patch based on the patch approved (fixed the odd variable name choice).

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://crash-stats-dev.allizom.org/report/list?range_value=7&range_unit=days&signature=F_181486744____________________________________________&version=Firefox%3A3.6.3:

[14:00:40.775] GET https://crash-stats-dev.allizom.org/report/list?range_value=7&range_unit=days&signature=F_181486744____________________________________________&version=Firefox%3A3.6.3 [HTTP/1.1 200 OK 142ms]

(So, it returns a 200 OK status.)

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot