Last Comment Bug 651078 - Make content/html/content/test/test_bug613113.html non flaky
: Make content/html/content/test/test_bug613113.html non flaky
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla6
Assigned To: Mounir Lamouri (:mounir)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks: FlakyTimeout
  Show dependency treegraph
 
Reported: 2011-04-19 04:26 PDT by Mounir Lamouri (:mounir)
Modified: 2011-04-20 02:51 PDT (History)
1 user (show)
mounir: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Should work (1.42 KB, patch)
2011-04-19 04:26 PDT, Mounir Lamouri (:mounir)
ehsan: review+
Details | Diff | Splinter Review

Description Mounir Lamouri (:mounir) 2011-04-19 04:26:26 PDT
Created attachment 526952 [details] [diff] [review]
Should work
Comment 1 :Ehsan Akhgari 2011-04-19 12:07:06 PDT
Comment on attachment 526952 [details] [diff] [review]
Should work

> output.addEventListener("invalid", function() {
>   if (invalidEvent) {
>     ok(false, "invalid event has already been caught");
>   } else {
>     invalidEvent = true;
>     ok(true, "invalid event has been caught");
>+    setTimeout(SimpleTest.finish, 0);

This will call finish with this set to window, I think.  Change this to:

setTimeout(function() {
  SimpleTest.finish();
}, 0);

r=me with that.
Comment 2 Mounir Lamouri (:mounir) 2011-04-20 02:51:03 PDT
Pushed:
http://hg.mozilla.org/mozilla-central/rev/13794a5bde53

Note You need to log in before you can comment on or make changes to this bug.