651107 - Allow waitForClipboard to check for any custom flavor

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

SimpleTest.waitForClipboard can currently only wait for text/unicode flavors, it could be more generic.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.0

This should be retro-compatible (the flavor is optional and defaults to text/unicode), I'll run on Try before proceeding with review request.

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.1

This includes only Linux because my previous try contained a typo, and didn't want to abuse of our resources. I've run tests on Win locally though.
http://tbpl.mozilla.org/?tree=MozillaTry&rev=096889f1e1ba

Comment 3

[(no longer active)]

Comment on attachment 527113 [details] [diff] [review]
patch v1.1

Looks good to me.  You may also want to ask ted to review the SimpleTest parts...

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 527113 [details] [diff] [review]
patch v1.1

ok, I think there isn't much more to review here, but let's send the request and he'll figure out if it's worth it :)

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 527113 [details] [diff] [review]
patch v1.1

We really need to move this into SpecialPowers, but this isn't really changing the situation any.

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/projects/places/rev/b87a0f69f78e

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I don't know much about SpecialPowers, is there some doc or a Wiki page to learn about it?

Comment 8

[(not currently active) Ted Mielczarek]

Indeed, there is:
https://developer.mozilla.org/en/SpecialPowers

Comment 9

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/b87a0f69f78e