Labels in account settings should wrap where appropriate

NEW
Unassigned

Status

7 years ago
4 years ago

People

(Reporter: squib, Unassigned)

Tracking

Trunk
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patchlove])

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Created attachment 527185 [details] [diff] [review]
Make some labels wrap

There are occasionally bug reports about labels getting cut off in the account settings dialog due to strings being longer than we expect. One easy way to fix this for the horizontal case would be to allow those labels to wrap. Here's a patch that does this.

As a followup, we could also make the dialog scrollable (which would fix the vertical case as well as really really small widths), and/or resize the window based on the content when it's loaded.
Attachment #527185 - Flags: feedback?(clarkbw)
Comment on attachment 527185 [details] [diff] [review]
Make some labels wrap

This looks ok to me, though I feel like we should land it and get some more testing.  I didn't get a chance to build TB to test this out.
Attachment #527185 - Flags: feedback?(clarkbw) → feedback+

Comment 2

4 years ago
(In reply to Bryan Clark (Firefox PM) [:clarkbw] from comment #1)
> Comment on attachment 527185 [details] [diff] [review]
> Make some labels wrap
> 
> This looks ok to me, though I feel like we should land it and get some more
> testing.  I didn't get a chance to build TB to test this out.

Jim are you able to finish it off?
Flags: needinfo?(squibblyflabbetydoo)
Whiteboard: [patchlove]
(Reporter)

Comment 3

4 years ago
Not likely, but I'll happily help anyone who wants to finish it.
Flags: needinfo?(squibblyflabbetydoo)
You need to log in before you can comment on or make changes to this bug.