Last Comment Bug 651546 - Remove stackLimit from GCMarker
: Remove stackLimit from GCMarker
Status: RESOLVED FIXED
fixed-in-tracemonkey
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: ---
Assigned To: Gregor Wagner [:gwagner]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-20 10:38 PDT by Gregor Wagner [:gwagner]
Modified: 2011-04-26 15:14 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (2.18 KB, patch)
2011-04-20 10:53 PDT, Gregor Wagner [:gwagner]
wmccloskey: review+
Details | Diff | Splinter Review

Description Gregor Wagner [:gwagner] 2011-04-20 10:38:38 PDT
The marking stack logic doesn't need it any more.
Comment 1 Gregor Wagner [:gwagner] 2011-04-20 10:39:35 PDT
Bill do you agree?
Comment 2 Bill McCloskey (:billm) 2011-04-20 10:52:40 PDT
(In reply to comment #1)
> Bill do you agree?

Yeah. I should have taken it out, but I forgot.
Comment 3 Gregor Wagner [:gwagner] 2011-04-20 10:53:42 PDT
Created attachment 527321 [details] [diff] [review]
patch
Comment 4 Bill McCloskey (:billm) 2011-04-20 10:54:38 PDT
Comment on attachment 527321 [details] [diff] [review]
patch

Thanks.
Comment 5 Gregor Wagner [:gwagner] 2011-04-20 12:23:24 PDT
http://hg.mozilla.org/tracemonkey/rev/c80e011b9bd1
Comment 6 Gregor Wagner [:gwagner] 2011-04-20 18:28:46 PDT
Igor how is this bug related to 651298?
Comment 7 Igor Bukanov 2011-04-20 18:54:03 PDT
(In reply to comment #6)
> Igor how is this bug related to 651298?

It is unrelated, but it touches the same areas in the code as that bug.
Comment 8 Chris Leary [:cdleary] (not checking bugmail) 2011-04-26 15:14:15 PDT
http://hg.mozilla.org/mozilla-central/rev/c80e011b9bd1

Note You need to log in before you can comment on or make changes to this bug.