651562 - Styling/copy for Contribution error message

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Load https://addons-next.allizom.org/en-us/firefox/search/?q=CensureBlock+&cat=all&x=0&y=0
2. click on the contribute link

expected behavior:
It is obvious that it is an error message. The error message mentions what went wrong and if applicable, tells what to do next.

observed behavior:
Error message looks like a success notification and copy is too vague. See screenshot

Comment 1

[Andy McKay]

Notification error icon added. Any suggested change in copy fligtar?

Existing: There was a problem communicating with Paypal.

Comment 2

[Wil Clouser [:clouserw]]

I get "There was a problem with that contribution." with no icon.

If it were "There was a problem communicating with Paypal." as in comment 1 I would have closed this bug as fixed as that's sufficiently nerdy to fend off people, but "problem with that contribution" makes it sound like it's my fault, in my opinion.  Am I hitting a different code branch than what you added?

Comment 3

[Andy McKay]

Sorry there's at the moment.

There was a problem communicating with Paypal.

This is when there's an authentication error. We've messed up settings or Paypal has altered our account. This should hardly ever happen.

There was a problem with that contribution.

We got through to paypal and there's one of those receiving errors, usually about the receivers account that we are talking to paypal about.

Comment 4

[Andy McKay]

s/at the moment/two at the moment/

grrr

Comment 5

[Wil Clouser [:clouserw]]

Does the second one have an icon?  I didn't see it when I tested.

If that's the error coming from paypal, that's good enough and we can close this.  I sent another email to paypal this morning about our issues.

Comment 6

[krupa raj[:krupa]]

We show the two errors Andy mentioned for the same add-on depending on which page the user makes the contribution.

STR:
1. 1. Load
https://addons-next.allizom.org/en-us/firefox/search/?q=CensureBlock+&cat=all&x=0&y=0
2. click on the contribute link
3. Notice the error message
4. try making the contribution from the add-on detail page
5. Notice the error mesage.

observed behavior:
We show 'There was a problem with that contribution.' for contributions from browse pages and 'There was a problem communicating with Paypal.' from add-on detail page

Comment 7

[Andy McKay]

Attachment: error

Comment 8

[Andy McKay]

The strings are slightly different on the pages. I should sync them up.

The error isn't the exact error returned by paypal, since I don't think exposing information about the receivers settings, so we have an opportunity to make is less vague if needed.

Comment 9

[Andy McKay]

The icon is added in anyway.

If anyone thinks of better text, let me know.

https://github.com/jbalogh/zamboni/commit/1f5256face051fc019b9ee22b368f638d604d5ce

Comment 10

[krupa raj[:krupa]]

Chowse, do you have any suggestions about this error message?

Comment 11

[Chris Howse [:chowse]]

(In reply to comment #10)
> Chowse, do you have any suggestions about this error message?

Looks fine to me. I could only recommend a few tweaks:

* Replace the blue border w/ a red border (I believe we use a #590702 border
  in a few other error/warning contexts).

* Provide some suggestions for what to do next, if anything makes sense.
  For example:

  "There was a problem communicating with PayPal.
   Please try again [in a few minuties | in a few hours | later]."

  or

  "There was a problem communicating with PayPal.
   Please contact [someone at AMO or PayPal] to report this problem."

Comment 12

[krupa raj[:krupa]]

Filed bug 652901, bug 652897 and bug 652906

marking this verified @ https://addons.allizom.org/en-us/firefox/search/?q=CensureBlock+&cat=all&x=0&y=0

Comment 13

[krupa raj[:krupa]]

Attachment: post-fix screenshot