Last Comment Bug 651801 - share a little more code between implementations of css3-animations and css3-transitions
: share a little more code between implementations of css3-animations and css3-...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: CSS Parsing and Computation (show other bugs)
: Trunk
: All All
: P4 normal (vote)
: mozilla6
Assigned To: David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-20 23:11 PDT by David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
Modified: 2011-04-21 20:24 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch 1: share code to count the length of the transition/animation array (10.05 KB, patch)
2011-04-20 23:14 PDT, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
bzbarsky: review+
Details | Diff | Review
patch 2: share code to compute timing functions (11.22 KB, patch)
2011-04-20 23:14 PDT, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
bzbarsky: review+
Details | Diff | Review

Description David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2011-04-20 23:11:18 PDT
While reviewing bug 435442, bzbarsky asked me to share a little more code in a few places as a followup.  I actually wrote the patches while he was reviewing, but didn't get around to uploading them.
Comment 1 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2011-04-20 23:14:05 PDT
Created attachment 527484 [details] [diff] [review]
patch 1: share code to count the length of the transition/animation array
Comment 2 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2011-04-20 23:14:24 PDT
Created attachment 527485 [details] [diff] [review]
patch 2: share code to compute timing functions
Comment 3 Boris Zbarsky [:bz] (Out June 25-July 6) 2011-04-21 14:10:15 PDT
Comment on attachment 527484 [details] [diff] [review]
patch 1: share code to count the length of the transition/animation array

r=me
Comment 4 Boris Zbarsky [:bz] (Out June 25-July 6) 2011-04-21 14:12:34 PDT
Comment on attachment 527485 [details] [diff] [review]
patch 2: share code to compute timing functions

r=me
Comment 5 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2011-04-21 20:24:33 PDT
https://hg.mozilla.org/mozilla-central/rev/04d855576596
https://hg.mozilla.org/mozilla-central/rev/8bec19370c0e

Note You need to log in before you can comment on or make changes to this bug.