Closed Bug 65185 Opened 24 years ago Closed 24 years ago

[BeOS] Bookmarks is not imported correctly

Categories

(Core Graveyard :: RDF, defect)

Product:
Core Graveyard
Component:
RDF
Platform:
x86
BeOS
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: toyoshim, Assigned: cls)

References

Details

Attachments

(2 files)

fixed :)
3.40 KB, patch
Details | Diff | Splinter Review
additional patch
1.03 KB, patch
Details | Diff | Splinter Review
Imported Bookmarks does not work :(
Attached patch fixed :) — — Splinter Review
reassign to cls. cc: ham!, cls
Assignee: toyoshim → cls
Marking new for diskussion and adding patch keyword.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: patch
In Moz 0.7 imported NetPositive bookmarks appreared to work for me (except there was no title on the imported folder - windows has "Imported IE Favourites"). I only had one bookmark in the netpositive folder, next time I reboot to BeOS I'll add quite a few NetPositive bookmarks to see if it still works.
First, the problem that there was no title on the imported folder was resolved at 65131. (it's from careless miss :) Next, ... Do imported bookmakrs work? In nsFileSystemDataSource.cpp, netPositiveDir was not initialized. So, all code that treat BeOS's file attributes is not executed! If you click imported bookmarks, mozilla will open the bookmark file itself but pointed URL. And original code import "META:url" attribute as is, but this attribute is written in UTF-8. Mozilla request UCS2 strings. So we shold convert it, or Japanese title will not appeared correctly.
Thanks for the patch. It has been checked in. Marking fixed.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
*** Bug 64877 has been marked as a duplicate of this bug. ***
Attached patch additional patch — — Splinter Review
If folders have META:title attribute, we should use it as names too. This behaviour is more look like Net+'s. Attachment 22563 [details] [diff] will fix it.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
has this patch been forgotten?
Not forgotten. It's in the queue along with about 10,000 other things. I'll be sure to get it into the next round of BeOS patch reviews & testing.
Patch has been checked in. Marking fixed.
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
Takashi, could you please verify this on BeOS? Thanks.
v
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: