Add comments explaining the formatting syntax for strings in utils

RESOLVED FIXED

Status

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: stas, Assigned: brez)

Tracking

Details

(Reporter)

Description

8 years ago
E.g.

https://github.com/mozilla/webifyme/blob/master/ff4/utils/trans_real.py

date_format = ugettext('DATE_FORMAT')

A comment for the localizers should specify what is the syntax to be used in this string.

See http://docs.djangoproject.com/en/dev/topics/i18n/internationalization/#comments-for-translators
(Reporter)

Updated

8 years ago
Blocks: 650033

Updated

8 years ago
Assignee: nobody → jbresnik
(Assignee)

Comment 1

8 years ago
Austin - we were chatting about this yesterday, what was the solution?

Comment 2

8 years ago
This was the L10n comment piece.
Example:
# L10n: A date format is in the following form ....

These comments are kept with the strings and end up in the po files.

Comment 3

8 years ago
(In reply to comment #0)
get_date_formats -
This is a very weird piece of code. Not sure where it came from or why it would be a get text string. Seems like you'd want to use the native i18n methods for date format.

We should nuke this or figure out how the app uses it.
(Assignee)

Comment 4

8 years ago
These are methods are not used in the app - removing them


[master b593bb2] removing unused methods
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.