Last Comment Bug 651874 - Wrong library prefixed in dependentlibs.list in mingw compilation
: Wrong library prefixed in dependentlibs.list in mingw compilation
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: ---
Assigned To: Jacek Caban
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-21 09:21 PDT by Jacek Caban
Modified: 2011-04-28 03:29 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix v1.0 (2.23 KB, patch)
2011-04-21 09:21 PDT, Jacek Caban
khuey: review+
Details | Diff | Splinter Review

Description Jacek Caban 2011-04-21 09:21:28 PDT
Created attachment 527556 [details] [diff] [review]
fix v1.0

It's generated by xpcom/stub/Makefile.in that uses $(LIB_PREFIX) to generate library name list resulting in eg. libxul.dll instead of xul.dll. It should use $(DLL_PREFIX) that is the same as LIB_PREFIX on all configs except mingw. The attached patch fixes the problem and should be no-op on other platforms.
Comment 1 Jacek Caban 2011-04-28 03:29:57 PDT
Thanks for review.

http://hg.mozilla.org/mozilla-central/rev/92302d33de17

Note You need to log in before you can comment on or make changes to this bug.