651921 - Browsing Marks: "view first" and "view last" mark doesn't work

Status: VERIFIED FIXED

(Websites Graveyard :: markup.mozilla.org, defect)

Description

[Matt Brandt [:mbrandt]]

Steps to reproduce:
1. Go to https://markup.allizom.org/en/#/linear/
2. In the Markup browsing pane, click "view first"
3. Click "view last"

Expected:
The user should be zoomed to either the first or last mark

Actual:
Nothing happens, there is no feedback to the user.

[11:04:14.903] b.currentMark is null @ https://markup.allizom.org/media/assets/js/markUp_app.min.js:29

Comment 1

[Adam Miller]

It looks like there are blank marks in the database. Please remove these then retest this. 

The blank marks may be there from before proper validation was put in place to prevent users from submitting blank marks.

Comment 2

[Matt Brandt [:mbrandt]]

Adam, what's the route for removing them. Can this be accomplished via the admin panel? Note this is what I have access to at the moment.

Comment 3

[Adam Miller]

No you have to do it by hand, sorry. Using a GUI or the command line should make it pretty clear which marks are bad and which are fine. The bad ones will have a very small or no data in the points_obj and points_obj_simplified columns. 

This is a cleanup we shouldn't have to do again. There was a bug that came up during QA that showed you could add marks w/o any data. 

The visualization and admin's moderate view are only designed to work with valid marks, so that's why you can't fix this through that screen. 

I'm about to commit some improvements to the javascript that will better handle some of these edge cases, but the improperly formed marks need cleared out before this particular issue with the First/Last buttons will be fixed.

Comment 4

[Fred Wenzel [:wenzel]]

All right, I filed an IT bug to wipe out the marks that have "null" (in base64) as their simplified points object.

Comment 5

[Matt Brandt [:mbrandt]]

Thanks Fred and Adam!

Comment 6

[Fred Wenzel [:wenzel]]

IT removed the empty marks. Matt, please take a look if this is fixed?

Comment 7

[Matt Brandt [:mbrandt]]

Removing the nulls from the db (bug 652147) appears to have cleaned this up nicely.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED.