JavaScript Error: "scrollbox.firstChild is null"

VERIFIED FIXED in Firefox 6

Status

Fennec Graveyard
General
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: wesj, Assigned: wesj)

Tracking

Trunk
Firefox 6

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 527808 [details] [diff] [review]
Patch

This shows up during a lot of test runs. When I updated the dialog theme, I also switched to using dialog elements in our main chrome. That also attaches the dialog binding which contains some properties that don't really apply to those dialogs.

This patch just removes the binding for these two guys.
(Assignee)

Updated

7 years ago
Attachment #527808 - Attachment is patch: true
Attachment #527808 - Attachment mime type: application/octet-stream → text/plain
Attachment #527808 - Flags: review?(mark.finkle)
Comment on attachment 527808 [details] [diff] [review]
Patch

can you just change the main binding to use:

dialog:not(.content-dialog) {
  -moz-binding: url("chrome://browser/content/bindings/dialog.xml#dialog");
}
(Assignee)

Comment 2

7 years ago
Created attachment 527843 [details] [diff] [review]
Patch v2

Sure.
Assignee: nobody → wjohnston
Attachment #527808 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #527808 - Flags: review?(mark.finkle)
Comment on attachment 527843 [details] [diff] [review]
Patch v2

I assume this works OK and you want a review :)
Attachment #527843 - Flags: review+
(Assignee)

Comment 4

7 years ago
http://hg.mozilla.org/mozilla-central/rev/6edb7954577c
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
Depends on: 652545

Comment 5

7 years ago
VERIFIED FIXED on:

Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a2) Gecko/20110705 Firefox/6.0a2 Fennec/6.0a2 

Device: HTC Desire Z (Android 2.2)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.