Closed Bug 652157 Opened 13 years ago Closed 13 years ago

JavaScript Error: "scrollbox.firstChild is null"

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 6

People

(Reporter: wesj, Assigned: wesj)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
This shows up during a lot of test runs. When I updated the dialog theme, I also switched to using dialog elements in our main chrome. That also attaches the dialog binding which contains some properties that don't really apply to those dialogs.

This patch just removes the binding for these two guys.
Attachment #527808 - Attachment is patch: true
Attachment #527808 - Attachment mime type: application/octet-stream → text/plain
Attachment #527808 - Flags: review?(mark.finkle)
Comment on attachment 527808 [details] [diff] [review]
Patch

can you just change the main binding to use:

dialog:not(.content-dialog) {
  -moz-binding: url("chrome://browser/content/bindings/dialog.xml#dialog");
}
Attached patch Patch v2Splinter Review
Sure.
Assignee: nobody → wjohnston
Attachment #527808 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #527808 - Flags: review?(mark.finkle)
Comment on attachment 527843 [details] [diff] [review]
Patch v2

I assume this works OK and you want a review :)
Attachment #527843 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/6edb7954577c
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
Depends on: 652545
VERIFIED FIXED on:

Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a2) Gecko/20110705 Firefox/6.0a2 Fennec/6.0a2 

Device: HTC Desire Z (Android 2.2)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: