JM: inline jsop_mod on 64-bit

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Currently jsop_mod always calls a stub on 64-bit and this is killing performance on the benchmark in bug 652303.
(Assignee)

Comment 1

6 years ago
Created attachment 527935 [details] [diff] [review]
Patch

Is it really this simple? This passes jit-test and jstests, will look more closely next week and ask for review.
Assignee: general → jandemooij
Status: NEW → ASSIGNED
(Assignee)

Updated

6 years ago
Attachment #527935 - Flags: review?(dvander)
Attachment #527935 - Flags: review?(dvander) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/tracemonkey/rev/e6c5fbc0b542
Whiteboard: fixed-in-tracemonkey
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/e6c5fbc0b542
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.