Closed
Bug 652341
Opened 13 years ago
Closed 13 years ago
Firefox Sync key document doesn't align to the right on RTL
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: tomer, Assigned: tomer)
References
()
Details
(Keywords: rtl, Whiteboard: [verified in services])
Attachments
(1 file)
682 bytes,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
When saving the syncKey.xhtml file to disk (Preferences → Sync → My Sync Key) or printing it, the result page will contain RTL content on RTL UI (currently Arabic/Farsi/Hebrew), but the page is missing dir=rtl which make it difficult to read. I purpose the following change: a. The document will get the UI direction. b. The key should be ALWAYS in LTR, because it may start with a digit which will be rendered in the wrong side of the string.
Attachment #527948 -
Flags: review?
Comment 1•13 years ago
|
||
Comment on attachment 527948 [details] [diff] [review] purposed patch Makes sense. Thanks for the patch!
Attachment #527948 -
Flags: review? → review+
Comment 2•13 years ago
|
||
Mounir, can you please take this in one of your landings?
Assignee: nobody → tomer
Keywords: checkin-needed
Comment 3•13 years ago
|
||
(In reply to comment #2) > Mounir, can you please take this in one of your landings? I will land this in services-central so that we can have Services QA verify this. Thanks for the review, Ehsan. I was wondering how I could verify this patch without having to switch my language to Farsi, Arabic or Hebrew :)
Assignee | ||
Comment 4•13 years ago
|
||
I've tested this addition manually by placing the patched file inside omni.jar, and willing to test the Hebrew nightly when this will be landed.
Comment 5•13 years ago
|
||
Pushed to s-c: http://hg.mozilla.org/services/services-central/rev/0e12d3b6027e Tomer, could you add STRs for our QA team?
Assignee | ||
Comment 6•13 years ago
|
||
a. Make sure you have sync configured on the browser. b. Navigate to Firefox → Preferences → Sync → Account Managment → My Sync Key c. Save this file to the disk, and open it with the browser. d. The file should include text in your browser locale, and if browser locale is {Arabic, Farsi, Hebrew} the text would be aligned to the right not including the sync key string itself. In view source, <body> with dir="rtl" for these locales, dir="ltr" to all other locales.
Comment 7•13 years ago
|
||
Not really able to verify in an rtl locale 'til this gets to stage where l10n builds are available. However, the body tag does have the correct dir="ltr" attribute for en-US build.
Whiteboard: [fixed in services] → [verified in services]
Comment 8•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0e12d3b6027e
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
Updated•6 years ago
|
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•