Closed
Bug 652355
Opened 13 years ago
Closed 13 years ago
Remove virtual accessor GetURIExternal from Link
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: khuey, Assigned: khuey)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
2.68 KB,
patch
|
sdwilsh
:
review+
|
Details | Diff | Splinter Review |
This was added in Bug 510202 and can go away now that we live in a libxul only world.
Assignee | ||
Comment 1•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Attachment #527959 -
Flags: review?(sdwilsh)
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → khuey
Comment 2•13 years ago
|
||
Comment on attachment 527959 [details] [diff] [review] Remove virtual accessor used as a non-libxul workaround now that disable-libxul is dead. r=sdwilsh
Attachment #527959 -
Flags: review?(sdwilsh) → review+
![]() |
||
Comment 3•13 years ago
|
||
Is this not meant for use by non-core code, then? _That_'s not linked into libxul....
Comment 4•13 years ago
|
||
(In reply to comment #3) > Is this not meant for use by non-core code, then? _That_'s not linked into > libxul.... That's a good point. Maybe we don't want this change?
Assignee | ||
Comment 5•13 years ago
|
||
Well, I got the impression that we did this just for that one use case ... if we don't want this, WONTFIX the bug.
Comment 6•13 years ago
|
||
So, who gets to make that call? Bz?
![]() |
||
Comment 7•13 years ago
|
||
Unless there's obvious harm from having this (which I don't see yet), I'd just keep it.
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•