The "Show Votes" page is completely broken

VERIFIED FIXED in Bugzilla 4.0

Status

()

Bugzilla
User Interface
--
major
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: rbgray, Assigned: Frédéric Buclin)

Tracking

(Blocks: 1 bug, {regression})

Bugzilla 4.0
regression
Dependency tree / graph
Bug Flags:
approval +
approval4.0 +
blocking4.0.1 +

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
Created attachment 527976 [details]
strikethrough on resolved bug

Visiting the Show Votes page for a resolved bug displays a page with strikethrough on most of the text.  This seems to be a regression from previous Bugzilla behavior.


Running: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0pre) Gecko/20110408 Firefox/4.0pre SeaMonkey/2.1b3

Comment 1

6 years ago
The page generated for id=voting/bug.html has:
> <span class="bz_closed"><a href="show_bug.cgi?id=652351"...

before the DOCTYPE; with no closing span tag; which is presumably why the strikethrough goes crazy.
(Assignee)

Comment 2

6 years ago
Things are even worse in Bugzilla 4.1.1. We broke it upstream.
Assignee: nobody → ui
Severity: normal → major
Component: Bugzilla: Other b.m.o Issues → User Interface
Product: mozilla.org → Bugzilla
QA Contact: other-bmo-issues → default-qa
Target Milestone: --- → Bugzilla 4.0
Version: other → 4.0
(Assignee)

Updated

6 years ago
Flags: blocking4.0.1+
Summary: Show Votes page for resolved bug has massive strikethrough → The "Show Votes" page is completely broken
(Assignee)

Updated

6 years ago
Depends on: 372979
(Assignee)

Comment 3

6 years ago
Created attachment 527997 [details] [diff] [review]
patch, v1

You cannot pass "FILTER ..." within [% PROCESS global/header.html.tmpl %]. You have to do it in two steps. I also added the bug summary to the page header, to make things easier to discover (this way, you don't need to hover the bug ID to discover what the bug is about).
Assignee: ui → LpSolit
Status: NEW → ASSIGNED
Attachment #527997 - Flags: review?(dkl)

Comment 4

6 years ago
Comment on attachment 527997 [details] [diff] [review]
patch, v1

Review of attachment 527997 [details] [diff] [review]:

Looks good to me.
Attachment #527997 - Flags: review?(dkl) → review+
(Assignee)

Updated

6 years ago
Flags: approval4.0+
Flags: approval+
(Assignee)

Comment 5

6 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified extensions/Voting/template/en/default/pages/voting/bug.html.tmpl
Committed revision 7783.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified extensions/Voting/template/en/default/pages/voting/bug.html.tmpl
Committed revision 7574.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
This has been merged and pushed to production on bmo.
VERIFIED on bmo production. The massive strikethrough has disappeared in the "Show Votes" pages for all resolved bugs that I checked.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.