652381 - The "Show Votes" page is completely broken

Status: VERIFIED FIXED

(Bugzilla :: User Interface, defect)

Description

[Rich Gray (:rbgray)]

Attachment: strikethrough on resolved bug

Visiting the Show Votes page for a resolved bug displays a page with strikethrough on most of the text.  This seems to be a regression from previous Bugzilla behavior.


Running: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0pre) Gecko/20110408 Firefox/4.0pre SeaMonkey/2.1b3

Comment 1

[Ed Morley [:emorley]]

The page generated for id=voting/bug.html has:
> <span class="bz_closed"><a href="show_bug.cgi?id=652351"...

before the DOCTYPE; with no closing span tag; which is presumably why the strikethrough goes crazy.

Comment 2

[Frédéric Buclin]

Things are even worse in Bugzilla 4.1.1. We broke it upstream.

Comment 3

[Frédéric Buclin]

Attachment: patch, v1

You cannot pass "FILTER ..." within [% PROCESS global/header.html.tmpl %]. You have to do it in two steps. I also added the bug summary to the page header, to make things easier to discover (this way, you don't need to hover the bug ID to discover what the bug is about).

Comment 4

[Max Kanat-Alexander]

Comment on attachment 527997 [details] [diff] [review]
patch, v1

Review of attachment 527997 [details] [diff] [review]:

Looks good to me.

Comment 5

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified extensions/Voting/template/en/default/pages/voting/bug.html.tmpl
Committed revision 7783.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
modified extensions/Voting/template/en/default/pages/voting/bug.html.tmpl
Committed revision 7574.

Comment 6

[Dave Miller [:justdave]]

This has been merged and pushed to production on bmo.

Comment 7

[Tony Mechelynck [:tonymec]]

VERIFIED on bmo production. The massive strikethrough has disappeared in the "Show Votes" pages for all resolved bugs that I checked.