652386 - wrongtree.html should preserve query params

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, enhancement)

Description

[Phil Ringnalda (:philor)]

If I follow a link to, say, http://tbpl.mozilla.org/?tree=Try&rev=75e254773d87 and wind up at http://tbpl.mozilla.org/wrongtree.html?tree=Try&rev=75e254773d87, I'd be better served by having the links in the body of wrongtree retain my &rev=.

Comment 1

[Arpad Borsos [:Swatinem]]

Attachment: remove wrongtree altogether

This cleans up wrongtree and noscript handling.
The only “ugly” thing about this patch is that the tree info dropdown is empty in the wrongtree case, otherwise th UI is the same as for standard tbpl, also with the mru list.

Comment 2

[Markus Stange [:mstange]]

Comment on attachment 532431 [details] [diff] [review]
remove wrongtree altogether

Review of attachment 532431 [details] [diff] [review]:
-----------------------------------------------------------------

::: css/style.css
@@ +160,5 @@
>  }
>  #pushes, .patches, .results {
>    list-style: none;
> +  margin: 0;
> +  padding: 0;

.patches definitely needs its padding-left: 40px (which was previously supplied by the UA default style).

::: index.html
@@ +41,5 @@
> +	<p id="wrongtree"></p>
> +	<ul id="pushes" class="initialload">
> +		<li id="nopushes">There are no pushes to be displayed. Use the down arrow to add older pushes.</li>
> +	</ul>
> +</div>

2 spaces instead of tabs, please

@@ +89,5 @@
>  <script type="text/javascript" src="js/UserInterface.js"></script>
>  <script type="text/javascript" src="js/LoadTracker.js"></script>
>  <script type="text/javascript" src="js/Controller.js"></script>
>  <script type="text/javascript" src="js/utils.js"></script>
> +<script type="text/javascript">Controller.init();</script>

Much better!

::: js/Controller.js
@@ -21,5 @@
>      var onlyUnstarred = ("onlyunstarred" in params) && (params.onlyunstarred == "1");
>      var jobName = ("jobname" in params) && params.jobname;
>  
> -    if (!(this.treeName in Config.treeInfo))
> -      throw "wrongtree"; // er, hm.

RIP dumb comment

@@ +26,5 @@
>      this._data = new Data(this.treeName, noIgnore, Config);
>      this._uiCallbacks = UserInterface.init(this, onlyUnstarred, pusher, jobName);
>  
> +    if (!(this.treeName in Config.treeInfo)) {
> +      $("#wrongtree").html(

I'd prefer all DOM accesses to be confined to UserInterface.js. Maybe just move this to an else branch in UserInterface._buildTreeInfo?

@@ +32,5 @@
> +        "Please choose a tree from the list on the upper left.<br/>" +
> +        'Maybe the tree youâre looking for is on the <a href="' +
> +        Config.alternateTinderboxPushlogURL + this.treeName +
> +        '">' + Config.alternateTinderboxPushlogName +
> +        ' version of Tinderboxpushlog</a>');

full stop missing after </a>

Comment 3

[Arpad Borsos [:Swatinem]]

(In reply to comment #2)
> ::: css/style.css
> @@ +160,5 @@
> >  }
> >  #pushes, .patches, .results {
> >    list-style: none;
> > +  margin: 0;
> > +  padding: 0;
> 
> .patches definitely needs its padding-left: 40px (which was previously
> supplied by the UA default style).

You are right, I added those 40px to .patches.

Other nits fixed as well: http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/d232b5758bbc

Comment 4

[Markus Stange [:mstange]]

Bustage fix:
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/806f7a80d834