652413 - Markup on certain BMO pages (eg show bug, buglist, enter bug) no longer validates

Status: RESOLVED INCOMPLETE

(bugzilla.mozilla.org :: General, defect)

Description

[Ed Morley [:emorley]]

Show_bug.cgi...
http://validator.nu/?doc=https%3A%2F%2Fbugzilla.mozilla.org%2Fshow_bug.cgi%3Fid%3D652410

(The show bug issues are not caused by bug 652389, since that only applies to logged in can confirm users).

Buglist.cgi...
http://validator.nu/?doc=https%3A%2F%2Fbugzilla.mozilla.org%2Fbuglist.cgi%3Fproduct%3DFirefox%26component%3DBuild%2520Config%26resolution%3D---%26list_id%3D17036

I checked some of the logged in pages using the direct input method here:
http://validator.w3.org/#validate_by_input+with_options
...and some of those didn't validate either (eg enter bug), but there isn't any way to give a link.

Thanks :-)

Comment 1

[David Lawrence [:dkl]]

(In reply to comment #0)
> Show_bug.cgi...
> http://validator.nu/?doc=https%3A%2F%2Fbugzilla.mozilla.org%2Fshow_bug.
> cgi%3Fid%3D652410

I will also file separate bugs about these errors as well as I see some obvious fixes. 
 
> Buglist.cgi...
> http://validator.nu/?doc=https%3A%2F%2Fbugzilla.mozilla.org%2Fbuglist.
> cgi%3Fproduct%3DFirefox%26component%3DBuild%2520Config%26resolution%3D---
> %26list_id%3D17036

The errors about sorttable_customkey are unavoidable at the moment as it is a way for sorttable.js to sort certain columns that cannot be sorted using normal alphanumeric algorithms. 

The other error about the space in the title= variable I will file a separate bug upstream to fix and set as blocker for this bug.

dkl

Comment 2

[Ed Morley [:emorley]]

Thanks David :-)

Comment 3

[Ed Morley [:emorley]]

Just going through my reported unclosed bugs saved search having a spring clean, and noticed this. No rush, but just checked and a few bits left (and a few new ones since, post browser ID change etc) :-)


http://validator.nu/?doc=https%3A%2F%2Fbugzilla.mozilla.org%2Fbuglist.cgi%3Fproduct%3DFirefox%26component%3DBuild%2520Config%26resolution%3D---%26list_id%3D17036

{
Error: Element img is missing required attribute alt.
From line 219, column 1; to line 219, column 113
/script>↩↩<img src="extensions/BrowserID/web/sign_in_orange.png" onclick="browserid_sign_in()" style="margin-bottom: -8px"> or↩

Error: Text not allowed in element form in this context.
From line 219, column 114; to line 221, column 4

...

Error: Text not allowed in element form in this context.
From line 7502, column 70; to line 7503, column 10

Error: Element img is missing required attribute alt.
From line 7610, column 1; to line 7610, column 113
/script>↩↩<img src="extensions/BrowserID/web/sign_in_orange.png" onclick="browserid_sign_in()" style="margin-bottom: -8px"> or↩

Error: Text not allowed in element form in this context.
From line 7610, column 114; to line 7612, column 4

Error: Element script is missing required attribute type.
From line 7688, column 1; to line 7688, column 8

Error: The /> syntax on void elements is not allowed. (This is an HTML4-only error.)
At line 7694, column 179
}


http://validator.nu/?doc=https%3A%2F%2Fbugzilla.mozilla.org%2Fshow_bug.cgi%3Fid%3D652410

{
Warning: A table row was 3 columns wide and exceeded the column count established by the first row (2).
From line 447, column 8; to line 448, column 9
↩ </td>↩ </tr>↩ ↩

Warning: A table row was 3 columns wide and exceeded the column count established by the first row (2).
From line 456, column 12; to line 457, column 9
</td>↩ </tr>↩

Warning: A table row was 3 columns wide and exceeded the column count established by the first row (2).
From line 615, column 10; to line 616, column 7
↩ </td>↩ </tr>↩↩ 

Error: Table column 3 established by element td has no cells beginning in it.
From line 446, column 12; to line 446, column 27
</td><td colspan="2">[bmo4.

Error: Element script is missing required attribute type.
From line 930, column 1; to line 930, column 8
pt>↩↩↩↩↩↩↩<script>↩ var

Error: Element link not allowed as child of element div in this context. (Suppressing further errors from this subtree.)
From line 932, column 10; to line 934, column 35
↩</script><link↩ href="extensions/TagNewUsers/web/style.css?1303571902"↩ rel="stylesheet" type="text/css" >↩↩<!--

Error: Element img is missing required attribute alt.
From line 1507, column 1; to line 1507, column 113
/script>↩↩<img src="extensions/BrowserID/web/sign_in_orange.png" onclick="browserid_sign_in()" style="margin-bottom: -8px"> or↩

Error: Text not allowed in element form in this context.
From line 1507, column 114; to line 1509, column 4
om: -8px"> or↩ ↩ <

Error: Element script is missing required attribute type.
From line 1585, column 1; to line 1585, column 8
</script>↩<script>↩//<![

Error: The /> syntax on void elements is not allowed. (This is an HTML4-only error.)
At line 1591, column 179
p;WT.tv=8.6.2"/></div>↩</noscr

Error: The for attribute of the label element must refer to a form control.
From line 416, column 13; to line 416, column 50
<label accesskey="s" for="short_desc"><u>S</

Error: The for attribute of the label element must refer to a form control.
From line 445, column 9; to line 445, column 53
>↩ <label for="status_whiteboard" accesskey="w"><b><u>

Error: The for attribute of the label element must refer to a form control.
From line 452, column 9; to line 452, column 44
>↩ <label for="keywords" accesskey="k">↩

Error: The for attribute of the label element must refer to a form control.
From line 510, column 9; to line 510, column 29
>↩ <label for="version"><b>Ver

Error: The for attribute of the label element must refer to a form control.
From line 520, column 9; to line 520, column 48
>↩ <label for="rep_platform" accesskey="h"><b>Pla

Error: The for attribute of the label element must refer to a form control.
From line 535, column 9; to line 535, column 44
>↩ <label for="priority" accesskey="i">↩

Error: The for attribute of the label element must refer to a form control.
From line 547, column 11; to line 547, column 40
<label for="target_milestone">↩

Error: The for attribute of the label element must refer to a form control.
From line 565, column 9; to line 565, column 46
>↩ <label for="qa_contact" accesskey="q"><b><u>

Error: The for attribute of the label element must refer to a form control.
From line 576, column 7; to line 576, column 46
l">↩ <label for="bug_file_loc" accesskey="u"><b>↩

Error: The for attribute of the label element must refer to a form control.
From line 590, column 5; to line 590, column 27
bel">↩ <label for="dependson">Depend

Error: The for attribute of the label element must refer to a form control.
From line 600, column 5; to line 600, column 39
bel">↩ <label for="blocked" accesskey="b"><u>B</

Error: The for attribute of the label element must refer to a form control.
From line 646, column 9; to line 646, column 41
>↩ <label for="newcc" accesskey="a"><b>CC 
}

Comment 4

[Ed Morley [:emorley]]

Upstream fixed a bunch of issues in bug 1137307.

Comment 5

[David Lawrence [:dkl]]

(In reply to Ed Morley [:emorley] (formerly :edmorley) from comment #4)
> Upstream fixed a bunch of issues in bug 1137307.

We will get those changes when we move to 5.0 soon. Should we WONTFIX this bug then?

dkl

Comment 6

[Ed Morley [:emorley]]

I don't mind either way