Straighten out the weirdness of Pinstripe's livemark-item.png and livemarkItem.png

RESOLVED FIXED in Firefox 6

Status

()

Firefox
Theme
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: philor, Assigned: philor)

Tracking

Trunk
Firefox 6
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 528015 [details] [diff] [review]
Fix v.1

Winstripe and Gnomestripe have a browser/skin/livemark-item.png which is the single image of a RSS waveform over a document icon, which they use for the menu icon for items in a livemark folder.

Pinstripe has a browser/skin/livemark-item.png, which contains enabled and disabled versions of that icon, plus two identical sets of the old "this page has feeds" icon from the addressbar in four phases, all of which are unused, and a browser/skin/places/livemarkItem.png which is the single image of a RSS waveform over a document icon, which it uses for the menu icon for items in a livemark folder.

The ten minutes it took me to figure out what Pinstripe was doing, and the five minutes it took me to explain what it was doing, are my justification for making it stop doing it.
Attachment #528015 - Flags: review?(dao)
Comment on attachment 528015 [details] [diff] [review]
Fix v.1

Review of attachment 528015 [details] [diff] [review]:

This actually belongs in places/, like gnomestripe is doing it already...
Attachment #528015 - Flags: review?(dao) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/mozilla-central/rev/339182917a3d
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
You need to log in before you can comment on or make changes to this bug.