Last Comment Bug 652447 - Straighten out the weirdness of Pinstripe's livemark-item.png and livemarkItem.png
: Straighten out the weirdness of Pinstripe's livemark-item.png and livemarkIte...
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: Firefox 6
Assigned To: Phil Ringnalda (:philor)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-24 11:45 PDT by Phil Ringnalda (:philor)
Modified: 2011-05-14 14:46 PDT (History)
0 users
philringnalda: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix v.1 (4.41 KB, patch)
2011-04-24 11:45 PDT, Phil Ringnalda (:philor)
dao+bmo: review+
Details | Diff | Splinter Review

Description Phil Ringnalda (:philor) 2011-04-24 11:45:07 PDT
Created attachment 528015 [details] [diff] [review]
Fix v.1

Winstripe and Gnomestripe have a browser/skin/livemark-item.png which is the single image of a RSS waveform over a document icon, which they use for the menu icon for items in a livemark folder.

Pinstripe has a browser/skin/livemark-item.png, which contains enabled and disabled versions of that icon, plus two identical sets of the old "this page has feeds" icon from the addressbar in four phases, all of which are unused, and a browser/skin/places/livemarkItem.png which is the single image of a RSS waveform over a document icon, which it uses for the menu icon for items in a livemark folder.

The ten minutes it took me to figure out what Pinstripe was doing, and the five minutes it took me to explain what it was doing, are my justification for making it stop doing it.
Comment 1 Dão Gottwald [:dao] 2011-04-24 16:45:12 PDT
Comment on attachment 528015 [details] [diff] [review]
Fix v.1

Review of attachment 528015 [details] [diff] [review]:

This actually belongs in places/, like gnomestripe is doing it already...
Comment 2 Phil Ringnalda (:philor) 2011-05-14 14:46:21 PDT
http://hg.mozilla.org/mozilla-central/rev/339182917a3d

Note You need to log in before you can comment on or make changes to this bug.