652449 - Turn on jstests in |make check| on linux only

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect)

Description

[Paul Biggar]

jstests is currently disabled on all platforms, but tinderbox shows it works fully on linux, even though there are problems on other platforms. So we should turn it on on linux at least, to try and prevent further regressions.

Comment 1

[Paul Biggar]

Attachment: Turn on jstests on linux only

This patch turns on jstests on linux only. That's the only platform on which they all work for all combinations of JITFLAGS.

Comment 2

[Paul Biggar]

Tryservered, just to be sure (still can't tryserver to SM builds unfortunately):

http://dev.philringnalda.com/tbpl/?tree=Try&rev=0252b9de0c15

Comment 3

[Jim Blandy :jimb]

Comment on attachment 528084 [details] [diff] [review]
Turn on jstests on linux only

Review of attachment 528084 [details] [diff] [review]:

Looks fine to me.

Comment 4

[Paul Biggar]

http://hg.mozilla.org/tracemonkey/rev/2919a6aa1ab7

Let's hope this sticks :-/

Comment 5

[Paul Biggar]

And backed out: http://hg.mozilla.org/tracemonkey/rev/268942ceb06f

TEST-UNEXPECTED-FAIL | js1_5/Array/regress-350256-02.js | -a -m
TEST-UNEXPECTED-FAIL | js1_5/Array/regress-350256-03.js | -a -m

and other flags settings, always involving the methodjit.

Comment 6

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/2919a6aa1ab7
http://hg.mozilla.org/mozilla-central/rev/268942ceb06f (backout)
Note: not marking as fixed because last changeset is a backout.

Comment 7

[Bryan Thrall [:bthrall]]

Currently, jstests are enabled via ./mach jstests.