Closed Bug 652506 Opened 13 years ago Closed 13 years ago

Remove WinCE code from xpcom

Categories

(Core :: XPCOM, defect)

All
Windows CE
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla6

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file, 1 obsolete file)

WinCE code is being slowly removed by bug 614720 - since it's broken, no longer supported, and only serves to complicate code maintenance. 

This bug is for the xpcom/* parts of the removal.

http://mxr.mozilla.org/mozilla-central/search?string=wince&find=/xpcom/
Attached patch Remove WinCE code from xpcom (obsolete) — Splinter Review
Also Hg rms the following due to now no longer being used:

xpcom/reflect/xptcall/src/md/win32/xptcinvoke_asm_ce.asm
http://mxr.mozilla.org/mozilla-central/search?string=xptcinvoke_asm_ce.asm

xpcom/reflect/xptcall/src/md/win32/xptcinvokece.cpp
http://mxr.mozilla.org/mozilla-central/search?string=xptcinvokece.cpp

xpcom/reflect/xptcall/src/md/win32/xptcstubs_asm_ce.asm
http://mxr.mozilla.org/mozilla-central/search?string=xptcstubs_asm_ce.asm

xpcom/reflect/xptcall/src/md/win32/xptcstubsce.cpp
http://mxr.mozilla.org/mozilla-central/search?string=xptcstubsce.cpp

For follow up in another bug (since outside xpcom and I also need to find out if this wants to be kept for future use):
-> After this patch, build/mobile/devicemanager-utils.py is now no longer used (http://mxr.mozilla.org/mozilla-central/search?string=devicemanager-utils.py), so can likely be removed.
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Comment on attachment 528092 [details] [diff] [review]
Remove WinCE code from xpcom

Passed try: http://dev.philringnalda.com/tbpl/?tree=Try&rev=6847256b7306

Thanks :-)
Attachment #528092 - Flags: review?(benjamin)
Blocks: 653319
Attachment #528092 - Flags: review?(benjamin) → review+
Only change is updated commit message to include r=bsmedberg.

Carrying forwards r+.
Attachment #528092 - Attachment is obsolete: true
Attachment #529355 - Flags: review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/1e7f4ce5636f
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
http://mxr.mozilla.org/mozilla-central/search?string=wince&find=/xpcom/
...returns 0 results.

-> Verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: