Closed
Bug 652506
Opened 13 years ago
Closed 13 years ago
Remove WinCE code from xpcom
Categories
(Core :: XPCOM, defect)
Tracking
()
VERIFIED
FIXED
mozilla6
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file, 1 obsolete file)
72.36 KB,
patch
|
emorley
:
review+
|
Details | Diff | Splinter Review |
WinCE code is being slowly removed by bug 614720 - since it's broken, no longer supported, and only serves to complicate code maintenance. This bug is for the xpcom/* parts of the removal. http://mxr.mozilla.org/mozilla-central/search?string=wince&find=/xpcom/
Assignee | ||
Comment 1•13 years ago
|
||
Also Hg rms the following due to now no longer being used: xpcom/reflect/xptcall/src/md/win32/xptcinvoke_asm_ce.asm http://mxr.mozilla.org/mozilla-central/search?string=xptcinvoke_asm_ce.asm xpcom/reflect/xptcall/src/md/win32/xptcinvokece.cpp http://mxr.mozilla.org/mozilla-central/search?string=xptcinvokece.cpp xpcom/reflect/xptcall/src/md/win32/xptcstubs_asm_ce.asm http://mxr.mozilla.org/mozilla-central/search?string=xptcstubs_asm_ce.asm xpcom/reflect/xptcall/src/md/win32/xptcstubsce.cpp http://mxr.mozilla.org/mozilla-central/search?string=xptcstubsce.cpp For follow up in another bug (since outside xpcom and I also need to find out if this wants to be kept for future use): -> After this patch, build/mobile/devicemanager-utils.py is now no longer used (http://mxr.mozilla.org/mozilla-central/search?string=devicemanager-utils.py), so can likely be removed.
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•13 years ago
|
||
Comment on attachment 528092 [details] [diff] [review] Remove WinCE code from xpcom Passed try: http://dev.philringnalda.com/tbpl/?tree=Try&rev=6847256b7306 Thanks :-)
Attachment #528092 -
Flags: review?(benjamin)
Updated•13 years ago
|
Attachment #528092 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Only change is updated commit message to include r=bsmedberg. Carrying forwards r+.
Attachment #528092 -
Attachment is obsolete: true
Attachment #529355 -
Flags: review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 4•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/1e7f4ce5636f
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
Assignee | ||
Comment 5•13 years ago
|
||
http://mxr.mozilla.org/mozilla-central/search?string=wince&find=/xpcom/ ...returns 0 results. -> Verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•