652527 - Widgets can be added with same ID

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Hernán Rodriguez Colmeiro (:peregrino)]

Widgets can be added with the same ID if the ID is a falsy character, and get no warning nor error about being added with the same ID.
This doesn't affect much if the Widget is added to the addon-bar, but if you try to add a widget to the nav-bar (by modifying widget.js), a not very helpful error about some frame.docShell being undefined in the symbiont module appears.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

(automatic reprioritization of 1.0 bugs)

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(Pushing all open bugs to the --- milestone for the new triage system)

Comment 3

[Erik Vold]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/299

Pointer to Github pull-request

Comment 4

[Erik Vold]

(In reply to Erik Vold from comment #3)
> Created attachment 580694 [details]
> Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/299
> 
> Pointer to Github pull-request

This bug was resolved by https://github.com/mozilla/addon-sdk/commit/ca272b37d but there is no test for this use case, so my patch is simply adding a test.

Comment 5

[Alexandre Poirot [:ochameau]]

Comment on attachment 580694 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/299

Looks good.
Thanks for this patch!

Comment 6

[Alexandre Poirot [:ochameau]]

Hum I was about to merge the pull request, but I have

Comment 7

[Alexandre Poirot [:ochameau]]

Hum I was about to merge the pull request, but I have a doubt around "falsey".
Isn't it a typo for "falsy" ?

Comment 8

[Erik Vold]

(In reply to Alexandre Poirot (:ochameau) from comment #7)
> Hum I was about to merge the pull request, but I have a doubt around
> "falsey".
> Isn't it a typo for "falsy" ?

It's not a word, and I see falsey used more than falsy on the web. It seems like it should be treated as 'likey' is afaict, but my english sucks =]

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/d4656a43201219bb87aa156aa0fd22e7b2256ef0
Merge pull request #299 from erikvold/bug-652527

bug 652527 adding test falsey widget ids r=@ochameau