Last Comment Bug 652555 - Search... on folder context menu should be Search Messages...
: Search... on folder context menu should be Search Messages...
Status: VERIFIED FIXED
: ux-consistency
Product: Thunderbird
Classification: Client Software
Component: Folder and Message Lists (show other bugs)
: unspecified
: x86 All
: -- minor (vote)
: Thunderbird 11.0
Assigned To: :aceman
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-25 09:48 PDT by Wayne Mery (:wsmwk, NI for questions)
Modified: 2012-02-23 08:16 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (1.22 KB, patch)
2011-11-12 11:02 PST, :aceman
bwinton: review-
bwinton: ui‑review+
Details | Diff | Splinter Review
patch v2 (2.84 KB, patch)
2011-12-15 11:57 PST, :aceman
bwinton: review+
Details | Diff | Splinter Review

Description Wayne Mery (:wsmwk, NI for questions) 2011-04-25 09:48:46 PDT
Search... on folder context menu should be Search Messages...

because 
1. it brings up a "Search Messages" dialog, not a "Search" dialog. 
2. There are 2 types of search (originally there was 3, with "quick search" in version 2), and we should be clear in differentiating "Search Messages" from "Search all messages" - Bug 652432 is an example of where confusion can result
Comment 1 Ludovic Hirlimann [:Usul] 2011-04-27 06:22:03 PDT
Wayne do you think you could do a patch for this ?

Blake before wayne starts trying to make a patch would you ui-r+ this ?
Comment 2 Blake Winton (:bwinton) (:☕️) 2011-04-27 06:42:35 PDT
Yeah, that sounds reasonable.  ui-r=me.
Comment 3 :aceman 2011-11-12 11:02:39 PST
Created attachment 574075 [details] [diff] [review]
patch

Does this need any other review beside ui?
Comment 4 Blake Winton (:bwinton) (:☕️) 2011-11-12 12:13:56 PST
Comment on attachment 574075 [details] [diff] [review]
patch

Review of attachment 574075 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to :aceman from comment #3)
> Does this need any other review beside ui?

It will need a regular review, but that can wait until after the ui-review.

Actually, since I'm here, and the patch is small, I'll just review it now, too.

The new text seems good to me, so you get a ui-r=me, but when you change a string, you'll need to change the identifier (and the places it's used), so that the localizers will know that there's a new string for them to translate, so I'm afraid I'm going to have to say r-, but I look forward to the next version of this patch.  :)

Thanks,
Blake.
Comment 5 :aceman 2011-11-12 12:23:41 PST
You mean the 'folderContextSearchMessages.label' identifier? Why change it? Don't the localizers' tools notify them when the original English text changes?
Well, had the ID been folderContextSearch.label it would make sense to change it to folderContextSearchMessages.label . But what now? :)
Comment 6 Blake Winton (:bwinton) (:☕️) 2011-11-12 12:27:43 PST
(In reply to :aceman from comment #5)
> You mean the 'folderContextSearchMessages.label' identifier?

Yes.

> Why change it?

So that the localizers will know it's changed.

> Don't the localizers' tools notify them when the original English text
> changes?

Sadly, no.  :)

> Well, had the ID been folderContextSearch.label it would make sense to
> change it to folderContextSearchMessages.label . But what now? :)

Yeah, I'm not sure what a good new label is.  We've resorted to stuff like "folderContextSearchMessages2.label" before, but that's not great.  I trust that you'll come up with something.  ;)

Later,
Blake.
Comment 7 :aceman 2011-11-12 12:33:47 PST
(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #6)
> > Don't the localizers' tools notify them when the original English text
> > changes?
> 
> Sadly, no.  :)

Really sad. On projects where I do translations (pootle and gettext based, this happens automatically, so changes are not missed).

> > Well, had the ID been folderContextSearch.label it would make sense to
> > change it to folderContextSearchMessages.label . But what now? :)
> 
> Yeah, I'm not sure what a good new label is.  We've resorted to stuff like
> "folderContextSearchMessages2.label" before, but that's not great.  I trust
> that you'll come up with something.  ;)

I'll try. But everything else will not keep the style of names in the rest of the menu.

So what about folderContextSearchMessage.label ('s' removed)?
Comment 8 :aceman 2011-11-14 08:16:03 PST
Or folderContextSearchForMessages.label .
Comment 9 Magnus Melin 2011-11-16 07:14:04 PST
(In reply to Wayne Mery (:wsmwk) from comment #0)
> Search... on folder context menu should be Search Messages...
> 
> because 
> 1. it brings up a "Search Messages" dialog, not a "Search" dialog. 
> 2. There are 2 types of search (originally there was 3, with "quick search"
> in version 2), and we should be clear in differentiating "Search Messages"
> from "Search all messages" - Bug 652432 is an example of where confusion can
> result

I think id prefer is as is myself, as it's short (which is important for context menus). Context menus don't have to match the title of whatever dialog pops up by invoking it. For 2) i don't really see it helping users differentiate - they certainly should be able to tell the views apart already. I don't think the user in bug 652432 was confused by it, it was only the questions that made it confusing :)
Comment 10 Wayne Mery (:wsmwk, NI for questions) 2011-11-16 08:03:38 PST
(In reply to Magnus Melin from comment #9)
> (In reply to Wayne Mery (:wsmwk) from comment #0)
> > Search... on folder context menu should be Search Messages...
> > 
> > because 
> > 1. it brings up a "Search Messages" dialog, not a "Search" dialog. 
> > 2. There are 2 types of search (originally there was 3, with "quick search"
> > in version 2), and we should be clear in differentiating "Search Messages"
> > from "Search all messages" - Bug 652432 is an example of where confusion can
> > result
> 
> I think id prefer is as is myself, as it's short (which is important for
> context menus). Context menus don't have to match the title of whatever
> dialog pops up by invoking it. For 2) i don't really see it helping users
> differentiate - they certainly should be able to tell the views apart
> already. 

Short is good. And I'd be happy to keep it the same and wouldn't care ... if the issue was nothing more than the semantics of what appears there.

But from a support perspective I can tell you users often either can't tell the difference, or don't express themselves well enough to help us tell which one they are seeing - not without coaching.  And getting the information out of them is all lost, unproductive time for our support people.


> I don't think the user in bug 652432 was confused by it, it was
> only the questions that made it confusing :)

perhaps my questions were inadequate. And yes, the user knew what he was describing, but that doesn't mean the description was completely adequate.  And I don't understand where you see in bug 652432 comment 0 anything the clearly indicates whether the user is describing gloda search/search all messages vs Search Messages.  Note "search all messages" is in the summary because I put it there.
Comment 11 Magnus Melin 2011-11-17 00:20:34 PST
(In reply to Wayne Mery (:wsmwk) from comment #10)
> perhaps my questions were inadequate. And yes, the user knew what he was
> describing, but that doesn't mean the description was completely adequate. 
> And I don't understand where you see in bug 652432 comment 0 anything the
> clearly indicates whether the user is describing gloda search/search all
> messages vs Search Messages.  Note "search all messages" is in the summary
> because I put it there.

I don't see anything saying which search version was meant, my point was that search is search to an end user, and changing the context menu isn't likely to  make them refer to it as "search messages" or "search all messages" depending on the case.
Comment 12 :aceman 2011-12-15 11:57:59 PST
Created attachment 582061 [details] [diff] [review]
patch v2
Comment 13 Blake Winton (:bwinton) (:☕️) 2011-12-15 12:18:53 PST
Comment on attachment 582061 [details] [diff] [review]
patch v2

Review of attachment 582061 [details] [diff] [review]:
-----------------------------------------------------------------

(You already had ui-r+, so you don't need to re-request it.)

I'm going to keep the ui-r+, despite Magnus's objections, for a couple of reasons.
1) Because it is also "Show Messages…" in the "Edit » Find" menu, and because it's not _too_ long.
2) (The less-convincing reason. ;) Because you're searching the messages in the folder, not the folder itself.

And the code seems good, so I'll give it an r=me.
Comment 14 :aceman 2011-12-15 12:26:57 PST
Thanks.

(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #13)
> I'm going to keep the ui-r+, despite Magnus's objections, for a couple of
> reasons.
> 1) Because it is also "Show Messages…" in the "Edit » Find" menu, and
> because it's not _too_ long.
You probably meant "Search mesages..." .
Comment 15 Mark Banner (:standard8) 2011-12-16 14:37:10 PST
Checked in: http://hg.mozilla.org/comm-central/rev/11f70d4e4624

Note You need to log in before you can comment on or make changes to this bug.