Closed Bug 652625 Opened 9 years ago Closed 9 years ago

Empty queries still get run because the list_id parameter is added to them

Categories

(Bugzilla :: Query/Bug List, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 4.0

People

(Reporter: ehsan, Assigned: dkl)

References

()

Details

(Whiteboard: [bmo4.0-resolved])

Attachments

(1 file)

I navigated to the URL above by accident today, and it redirected me to <https://bugzilla.mozilla.org/buglist.cgi?list_id=39880> which seems to take forever to load.
I got this too (on Linux x86_64) but with ?list_id=41822 at the end. After some time my browser's (Sm 2.2a1pre) status line changes to "Done" and the tab's throbber changes to the default icon, but I still see the bug-munching dragon ("Please wait while your bugs are retrieved") as the page contents.
OS: Mac OS X → All
Hardware: x86 → All
P.S. After submitting comment #1, I see at the top of this page, between the emails and the summary:

Bug List: (69647 of 626402) First Last Prev Next   Show last search results 

which apparently is a consequence of that "eternal" search.
Basically the bug is that it should not be searching on empty quicksearch terms anyway and seems like it it trying to load *all* bugs. I will take a look at this.
Assignee: nobody → dkl
Status: NEW → ASSIGNED
I have verified that this is also the case on https://landfill.bugzilla.org/bugzilla-4.0-branch/.

If you enter https://landfill.bugzilla.org/bugzilla-4.0-branch/buglist.cgi?quicksearch= it will try to load all bugs in the database. This is due to a new feature in 4.0 that stores recent search buglists in a profile_search table. In Bugzilla::CGI::redirect_search_url it will first clean the query url which removes the empty quicksearch term but then it doesn't check for empty params. It then creates an empty placeholder list_id in profile_search and redirects to it.

I am attaching a patch that seems to fix this issue for me on my test instance. 

dkl
Component: Bugzilla: Other b.m.o Issues → Query/Bug List
Product: mozilla.org → Bugzilla
QA Contact: other-bmo-issues → default-qa
Version: other → 4.0
This patch also checks for non-empty CGI params before creating a placeholder list_id value in profile_search.

dkl
Attachment #528414 - Flags: review?(mkanat)
This patch is now running on BMO and seems to fix the problem.
dkl
Whiteboard: [bmo4.0-resolved]
WFM at BMO -- now I get an error page ("You may not search, or create saved searches, without any search terms.") instad of what I described in comment #1 and #2.
Whiteboard: [bmo4.0-resolved] → [bmo4.0-verified]
Whiteboard: [bmo4.0-verified] → [bmo4.0-resolved]
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Oops. Closed prematurely. Still waiting on upstream review.

dkl
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Summary: An empty quicksearch query takes you to a strange page which doesn't load! → Empty queries still get run because the list_id parameter is added to them
Target Milestone: --- → Bugzilla 4.0
Comment on attachment 528414 [details] [diff] [review]
Patch to fix loading of many bugs with empty quicksearch (v1)

Cool, this looks right. On checkin, though, make sure to add a comment above the block explaining why you are checking $self->param.
Attachment #528414 - Flags: review?(mkanat) → review+
Flags: approval4.0+
Flags: approval+
Thanks!

trunk:
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bugzilla/trunk
modified Bugzilla/CGI.pm
Committed revision 7806.

4.0:
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bugzilla/4.0
modified Bugzilla/CGI.pm
Committed revision 7591.

dkl
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Depends on: 654921
You need to log in before you can comment on or make changes to this bug.