652625 - Empty queries still get run because the list_id parameter is added to them

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[(no longer active)]

I navigated to the URL above by accident today, and it redirected me to <https://bugzilla.mozilla.org/buglist.cgi?list_id=39880> which seems to take forever to load.

Comment 1

[Tony Mechelynck [:tonymec]]

I got this too (on Linux x86_64) but with ?list_id=41822 at the end. After some time my browser's (Sm 2.2a1pre) status line changes to "Done" and the tab's throbber changes to the default icon, but I still see the bug-munching dragon ("Please wait while your bugs are retrieved") as the page contents.

Comment 2

[Tony Mechelynck [:tonymec]]

P.S. After submitting comment #1, I see at the top of this page, between the emails and the summary:

Bug List: (69647 of 626402) First Last Prev Next   Show last search results 

which apparently is a consequence of that "eternal" search.

Comment 3

[David Lawrence [:dkl]]

Basically the bug is that it should not be searching on empty quicksearch terms anyway and seems like it it trying to load *all* bugs. I will take a look at this.

Comment 4

[David Lawrence [:dkl]]

I have verified that this is also the case on https://landfill.bugzilla.org/bugzilla-4.0-branch/.

If you enter https://landfill.bugzilla.org/bugzilla-4.0-branch/buglist.cgi?quicksearch= it will try to load all bugs in the database. This is due to a new feature in 4.0 that stores recent search buglists in a profile_search table. In Bugzilla::CGI::redirect_search_url it will first clean the query url which removes the empty quicksearch term but then it doesn't check for empty params. It then creates an empty placeholder list_id in profile_search and redirects to it.

I am attaching a patch that seems to fix this issue for me on my test instance. 

dkl

Comment 5

[David Lawrence [:dkl]]

Attachment: Patch to fix loading of many bugs with empty quicksearch (v1)

This patch also checks for non-empty CGI params before creating a placeholder list_id value in profile_search.

dkl

Comment 6

[David Lawrence [:dkl]]

This patch is now running on BMO and seems to fix the problem.
dkl

Comment 7

[Tony Mechelynck [:tonymec]]

WFM at BMO -- now I get an error page ("You may not search, or create saved searches, without any search terms.") instad of what I described in comment #1 and #2.

Comment 8

[David Lawrence [:dkl]]

Oops. Closed prematurely. Still waiting on upstream review.

dkl

Comment 9

[Max Kanat-Alexander]

Comment on attachment 528414 [details] [diff] [review]
Patch to fix loading of many bugs with empty quicksearch (v1)

Cool, this looks right. On checkin, though, make sure to add a comment above the block explaining why you are checking $self->param.

Comment 10

[David Lawrence [:dkl]]

Thanks!

trunk:
Committing to: bzr+ssh://[e-mail]/bugzilla/trunk
modified Bugzilla/CGI.pm
Committed revision 7806.

4.0:
Committing to: bzr+ssh://[e-mail]/bugzilla/4.0
modified Bugzilla/CGI.pm
Committed revision 7591.

dkl