Closed Bug 652670 Opened 9 years ago Closed 9 years ago

treerows in disabled trees shouldn't be selectable in Aero theme

Categories

(Thunderbird :: OS Integration, defect, trivial)

All
Windows 7
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 5.0b1

People

(Reporter: squib, Assigned: Paenglab)

References

Details

Attachments

(1 file, 1 obsolete file)

It seems that in the Aero theme for Thunderbird, treerows can be selected even when the tree is disabled. I'm guessing that this is due to theming in messenger-aero.css, but since I don't have Windows Vista/7, it's hard for me to test that.
Richard, do you have some time to look into this?

Thanks,
Blake.
I can take this Bug.

I'm not sure, where I should put the definition. In messenger.css as global rule (tree[disabled="true"] > treechildren::-moz-tree-row(hover) ) or in accountManage.css as #archiveTree > treechildren? Globally would affecting every disabled tree, but I'm knowing only #archiveTree as a disabled tree. So I'm favoring more accountManage.css. Under Win7 the twisty has also a hover effect in disabled tree (this time not my fault ;), this is in toolkit). For this it would also be easier to add rules in accountManage.css.

What do you mean, Blake?
Attached patch Make treerows inactive (obsolete) — Splinter Review
I put the rules in accountManage.css because I think it fits better here. The twistys are also defined to eliminate the hover effect.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #528706 - Flags: review?(bwinton)
We should probably file a toolkit bug for the hover effect part. I'm guessing that any bug in messenger-aero.css should be fixed there, since it should(?) just require changing some of the rules, not adding new ones. The toolkit rules for non-aero themes seem to work right with disabled trees...
The treerow hover effect is a specialty of Win7 Explorer and this was made under TB for parity. FF has no such treelists (except DOMi or about:config) which are used all the time like TB. So they aren't forced to use this hover effect. Maybe the twisty hover issue could be successful.
The twisty part should probably be fixed at the source, since it could affect other users of toolkit. Firefox probably doesn't care, but I imagine other people might.

In the longer term, we might want to see if toolkit wants our treeview style changes.
Comment on attachment 528706 [details] [diff] [review]
Make treerows inactive

Review of attachment 528706 [details] [diff] [review]:

I agree that in the longer term, we probably want toolkit to do this for us, but for now, r=me for this quick fix, with the change I requested.  ;)

Thanks,
Blake.

::: mail/themes/qute/mail/accountManage-aero.css
@@ +1,4 @@
+%include accountManage.css
+
+@media all and (-moz-windows-default-theme) {
+  #archiveTree > treechildren::-moz-tree-row {

I think I would prefer it if we did this (and the other two rules below) by checking for trees with disabled="true".
Attachment #528706 - Flags: review?(bwinton) → review+
(In reply to comment #7)
> I think I would prefer it if we did this (and the other two rules below) by
> checking for trees with disabled="true".

Do you mean in messenger.css? I can do a new patch.
Either place is fine with me.

Thanks,
Blake.
In AccountCentral archiveTree is the only tree in disabled state. Messenger.css is more global and better for future trees in disabled state.
Now using tree[disabled="true"] in messenger.css
Attachment #528706 - Attachment is obsolete: true
Attachment #529206 - Flags: review?(bwinton)
Comment on attachment 529206 [details] [diff] [review]
more global approach

Review of attachment 529206 [details] [diff] [review]:

I like it!

Thanks,
Blake.
Attachment #529206 - Flags: review?(bwinton) → review+
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/5a5d809c944a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a4
You need to log in before you can comment on or make changes to this bug.