Closed Bug 652714 Opened 13 years ago Closed 13 years ago

Splinter reviews should not require a comment

Categories

(bugzilla.mozilla.org :: Splinter, defect)

Product:
bugzilla.mozilla.org
Component:
Splinter
Version:
Production
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: roc, Assigned: dkl)

References

Details

Splinter won't let you submit a review with no comment. I frequently want to do this. I can work around it by submitting a comment consisting of a single space, but it would be better not to have to.
Component: Bugzilla: Other b.m.o Issues → Splinter
Product: mozilla.org → bugzilla.mozilla.org
QA Contact: general → splinter
Version: other → Current
Will look at making the overall comment optional.
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Committed and will be in the next code update of BMO. Now when you merely change a flag to something else, it should enable the "Publish" button to allow committing the change.

Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.0
modified extensions/Splinter/template/en/default/pages/splinter.html.tmpl
modified extensions/Splinter/web/splinter.js
Committed revision 7657.

dkl
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Thanks, that's an improvement, but ... what if I want to submit comments on individual patch hunks, but not an overall comment, and I don't want to mark the patch r+ yet?
It will allow you to publish. Currently one of three things must happen for the publish button to work.

1) Add an overall comment
2) Add one or more review comments
3) Make a flag change

dkl
OK, brilliant. Thanks!
Depends on: 654921
You need to log in before you can comment on or make changes to this bug.