Closed
Bug 652731
Opened 13 years ago
Closed 13 years ago
Remove check for ZIP in js/src configure, since spidermonkey does not require it
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: emorley, Assigned: emorley)
Details
(Whiteboard: wanted-standalone-js)
Attachments
(1 file, 1 obsolete file)
1.94 KB,
patch
|
emorley
:
review+
|
Details | Diff | Splinter Review |
Per Wes' request... Building spidermonkey standalone requires ZIP be present (http://mxr.mozilla.org/mozilla-central/source/js/src/configure.in#979), even though it's not used / needed for the build to complete. This results in delightful workarounds along the lines of: ln -s /bin/true /bin/zip ...on every new machine used; so Wes would like the check removed. Occurrences of ZIP in /js/src: http://mxr.mozilla.org/mozilla-central/search?string=ZIP&find=/js/src/&case=on Of those, jsconfig.mk is being removed in bug 647388 and the rules.mk entry is only used for chrome packaging, so is only there to keep check-sync-dirs happy. Therefore the check for ZIP is indeed superfluous.
Assignee | ||
Comment 1•13 years ago
|
||
Doh, the two MXR links should be the other way around...
Assignee | ||
Updated•13 years ago
|
Summary: Remove check for ZIP in JS configure, since spidermonkey does not require it → Remove check for ZIP in js/src configure, since spidermonkey does not require it
Assignee | ||
Comment 2•13 years ago
|
||
Seeing as I was removing the ZIP check, it seemed sensible to just remove the ZIP defines & MOZ_PATH_PROGS altogether, since none of it is used. Plus this way if spidermonkey ever requires ZIP in the future, putting the check back in won't be forgotten. Also removed UNZIP, since it's not used either. ZIP: http://mxr.mozilla.org/mozilla-central/search?string=ZIP&find=/js/src&case=on UNZIP: http://mxr.mozilla.org/mozilla-central/search?string=UNZIP&find=/js/src&case=on
Attachment #528250 -
Flags: review?(jimb)
Assignee | ||
Comment 3•13 years ago
|
||
Ok, this time it wasn't me! The swapped links in comment 2 are due to some weird BMO bug, have filed bug 652740.
Assignee | ||
Comment 4•13 years ago
|
||
Sorry for the spam, but bug 652740 (BMO auto linkification swapping links around) has been fixed, so the comments above are now displaying correctly. As such, please disregard comment 1 and comment 3.
Assignee | ||
Comment 5•13 years ago
|
||
http://dev.philringnalda.com/tbpl/?tree=Try&rev=1974491cd478
Assignee | ||
Comment 6•13 years ago
|
||
Jim, ping for review please :-) Thanks!
Comment 7•13 years ago
|
||
Comment on attachment 528250 [details] [diff] [review] Remove js/src configure & autoconf ZIP/UNZIP references Review of attachment 528250 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me.
Attachment #528250 -
Flags: review?(jimb) → review+
Assignee | ||
Comment 8•13 years ago
|
||
Updated to tip, carrying forwards r+. Thanks for the review :-)
Attachment #528250 -
Attachment is obsolete: true
Attachment #532022 -
Flags: review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 9•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/9260062de89b
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
Updated•13 years ago
|
Keywords: checkin-needed
Updated•13 years ago
|
Whiteboard: wanted-standalone-js
You need to log in
before you can comment on or make changes to this bug.
Description
•