Closed Bug 652740 Opened 13 years ago Closed 13 years ago

"Attachment created" comment swapped attachment URL with a MXR URL inside the comment

Categories

(bugzilla.mozilla.org :: General, defect)

x86
Windows 7
defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: emorley, Unassigned)

References

Details

(Whiteboard: [comment 0 malformed by the bug it was describing, see comment 3])

Attachments

(1 file)

The attachment/comment I've just added in bug 652731 comment 2 has come out malformed.

The normal "Created attachment 999999 [details]" text/link at the start of the comment was swapped with one of the MXR links that was inside the comment.

ie:
1) Bug 652731
2) Add an attachment
3 [review]) Attached file and added the following comment:
-------
Seeing as I was removing the ZIP check, it seemed sensible to just remove the ZIP defines & MOZ_PATH_PROGS altogether, since none of it is used. Plus this way if spidermonkey ever requires ZIP in the future, putting the check back in won't be forgotten. Also removed UNZIP, since it's not used either.

ZIP: 
http://mxr.mozilla.org/mozilla-central/search?string=ZIP&find=/js/src&case=on

UNZIP:
http://mxr.mozilla.org/mozilla-central/search?string=UNZIP&find=/js/src&case=on
-------


Expected:
"Created attachment 999999 [details]"
<attachment name>

<attachment comment; not altered>


Actual:
"Created http://mxr.mozilla.org/mozilla-central/search?string=ZIP&find=/js/src&case=on"
<attachment name>

<attachment comment; but the first URL now reads: "attachment 528250 [details] [diff] [review]">
Ok, it's just done the same thing to the above.

Oh well; least it demonstrates the problem!
Attached file Raw message text that
Attaching as txt so the original text can be seen (seeing as I'm not able to post without it coming out malformed).
Severity: normal → major
Keywords: dataloss
Replacement for comment 0, seeing as it came out malformed...

1) Go to any bug
2) Add an attachment with comment message equal to that in the file attached to this bug

Expected:
The usual attachment created text/link shown, followed by the attachment name and then the unmodified attachment comment.

Actual:
Anything that would have been turned into a link has been swapped around with other links in that comment.

Examples being comment 0 here and also bug 652731 comment 2.
Whiteboard: [comment 0 malformed by the bug it was describing, see comment 3]
This was due to a change checked in to fix another auto-linkification issue that had negative side effects. I have reverted the previous fix now. Please verify that the attachment links are working again for you.

dkl
Backing out bug 652663 / http://bzr.mozilla.org/bmo/4.0/revision/7617 has indeed fixed the problem, thanks. Bug 652731 comment 0, bug 652731 comment 2 and most of comment 0 here are back to normal.

The only issue remaining (and I suspect this is unrelated, so I'll file another bug about it) is that in comment 0; the auto linkification of "attachment" followed by a number, occurs even with a newline in-between, making my STR in comment 0 read really badly. I also don't remember the BMO 3.x linkification for "attachment X" being quite so aggressive in what it replaced.

Either way, removing dataloss keyword since this is only affecting how comments are displayed and not the actual values in the DB.

Thanks :-)
Blocks: 652663
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: dataloss
Resolution: --- → FIXED
Component: Bugzilla: Other b.m.o Issues → General
Product: mozilla.org → bugzilla.mozilla.org
You need to log in before you can comment on or make changes to this bug.