652804 - Append "Bar" to the names of bar items in browser

Status: NEW

(SeaMonkey :: UI Design, defect)

Description

[Aki Laaksovirta]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; fi-FI; rv:1.9.2.16) Gecko/20110323 Ubuntu/10.04 (lucid) Firefox/3.6.16
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; fi-FI; rv:1.9.2.16) Gecko/20110323 Ubuntu/10.04 (lucid) Firefox/3.6.16

In the "Customize Toolbar" window of the browser, the search bar and search button are both labeled as "Search". There is a chance of mistake here! They should definitely have different labels: something like "Search Bar" for the bar and "Search" for the search button. Same goes for the location bar: it should be labeled "Location Bar" instead of just "Location".

Reproducible: Always

Steps to Reproduce:
1. Open the Customize Toolbar window from a Browser window.
2. Drag the Search button and the Location bar off the toolbar.

Actual Results:  
Search Button is labeled "Search" and the Search Bar is also labeled "Search".
Location Bar is labeled "Location".

Expected Results:  
Search Button should be labeled "Search" (or even "Search Button", maybe).
Search Bar should be labeled "Search Bar".
Location Bar should be labeled "Location Bar".

Comment 1

[Aki Laaksovirta]

Attachment: Proposed patch for search bar.

Comment 2

[Aki Laaksovirta]

Attachment: Proposed patch for location bar.

Comment 3

[Philip Chee]

Sounds reasonable but our UI person is Neil I'll shift the review requests to him for you.

Comment 4

[Philip Chee]

Before I do can you cosolidate both patches into one and upload a new patch? And set the reviewer to neil@parkwaycc. Thanks.

Comment 5

[Aki Laaksovirta]

Attachment: Proposed fix for both bars.

Comment 6

[Philip Chee]

<http://mxr.mozilla.org/mozilla2.0/source/browser/locales/en-US/chrome/browser/browser.dtd#128>
Firefox uses just "Location" and "Search".

How about we change our &searchButton.label; from "Search" to "Search Button"?

Comment 7

[Philip Chee]

Neil suggests removing the Title from the search button container since it's superflous e.g. when in the customize window.

Comment 8

[[e-mail]]

And the Go button while we're there, of course.

Comment 9

[Aki Laaksovirta]

Attachment: Proposed fix 2.0

This one has previous fixes + it removes titles from containers.

Comment 10

[[e-mail]]

(In reply to comment #7)
> Neil suggests removing the Title from the search button container since it's
> superflous e.g. when in the customize window.
That was supposed to be instead of the original suggestion. (I thought I'd commented on this earlier. Sorry for keeping you waiting.)

Comment 11

[Aki Laaksovirta]

Now, who supposes what?