652912 - Locale detection is broken, doesn't respect the accepted locales

Status: VERIFIED FIXED

(Websites Graveyard :: markup.mozilla.org, defect, P1)

Description

[Staś Małolepszy :stas]

I'm not sure how localeurl.middleware.LocaleURLMiddleware works, but it doesn't seem to take into account the accepted locales defined in the LANGUAGES array in https://github.com/mozilla/markup/blob/master/ffdemo/settings.py#L50. 

If I visit the staging site with the following locale prefs: (pl, fr), I see English, and I should see French (French is the first accepted locales on the list.)

Comment 1

[[:brez]]

I don't understand - are the translations done?  If not, you will only ever see English

Comment 2

[[:brez]]

Stas - assign this to you so you can answer...

Comment 3

[Austin King [:ozten]]

I checked out http://svn.mozilla.org/projects/l10n-misc/trunk/markup/locale/ into a local directory

ffdemo/locale

I edited the es django.po
I added es to the list of supported locales in settings.py
I restarted my server.

I didn't see the Spanish strings :(

Comment 4

[Staś Małolepszy :stas]

Right now, independent of my browser's language preferences, I'm always served en-US on the staging server.

(Back when I filed this bug, the locale detection would only look on the first language in my preferences, and if it wasn't on the supported locales list in settings, it would fall back to en-US, instead of looking at my second preference, third, and so on.)

Comment 5

[Austin King [:ozten]]

Just to clarify a part of a test plan...

Locale detection Use Case
1) Switch primary language of Firefox 4 to French
2) http://209.20.77.205/

Actual
Redirected to http://209.20.77.205/en-US/#/

Expected
Redirected to http://209.20.77.205/fr/#/

Comment 6

[Austin King [:ozten]]

Attachment: Adding commons, tower, etc

By adding tower, jingo, commons/middleware.py etc i've got the fr redirect working locally for the homepage.

Cursory testing, this breaks mark submission, so I'm digging into why.

Comment 7

[Austin King [:ozten]]

This should work now. I've added our usual middleware as well as jingo.

fr redirection works.
I've tested with fake Spanish strings, and gettext is working.

https://github.com/mozilla/markup/commit/120e63cd0cb5a408d2ac502596e83ef5d637d33b

https://github.com/mozilla/markup-lib/commit/9b6096ac13ffbad4febad825f10104c342b4b28c

Comment 8

[Austin King [:ozten]]

Not seeing the fix on stage. Troubleshooting in Bug#655271

Comment 9

[Staś Małolepszy :stas]

Comment on attachment 530471 [details] [diff] [review]
Adding commons, tower, etc

Review of attachment 530471 [details] [diff] [review]:
-----------------------------------------------------------------

::: ffdemo/settings.py
@@ +61,5 @@
>          from product_details import product_details
> +        return dict([(lang.lower(), product_details.languages[lang]['native'])
> +                     for lang in KNOWN_LANGUAGES])
> +
> +LANGUAGES = lazy(LazyLangs, dict)()

Any specific reason why you changed the tuple to a dict?  I think this broke the lang switcher in the footer.

Comment 10

[Staś Małolepszy :stas]

I filed bug 655305 to address comment 9.

Otherwise, the locale detection works very well now.  Thanks a ton, Austin!

Comment 11

[Austin King [:ozten]]

This data structure is required by our middleware.
I'll look at updating the lang drop down.

Comment 12

[Staś Małolepszy :stas]

Filed another follow-up: bug 655875.

Comment 13

[Staś Małolepszy :stas]

This works as expected now, thanks Austin.