nsXULDocument doesn't unlink enough

RESOLVED FIXED

Status

()

Core
XUL
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 528442 [details] [diff] [review]
patch

If nodes' ownerDocument is made a strong, we leak XULDocuments because it doesn't
unlink mTemplateBuilderTable.
Attachment #528442 - Flags: review?(peterv)
Comment on attachment 528442 [details] [diff] [review]
patch

Would it make sense to make nsXULDocument::SetTemplateBuilderFor check if aBuilder is non-null before creating a new BuilderTable? I'm worried about unlinking of other objects ending up calling SetTemplateBuilderFor with a null aBuilder.
Add a comment that we should unlink all the other stuff that we traverse too.
(Assignee)

Comment 2

6 years ago
Created attachment 528568 [details] [diff] [review]
patch
Attachment #528442 - Attachment is obsolete: true
Attachment #528442 - Flags: review?(peterv)
Attachment #528568 - Flags: review?(peterv)
Attachment #528568 - Flags: review?(peterv) → review+
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/mozilla-central/rev/557466969ba2
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.