652982 - [READY] test_close_on_last_window.xul needs to be explicit about its timeout requirements

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[(no longer active)]

See the discussion in bug 544356 comment 56 onwards.

Comment 1

[(no longer active)]

What should happen here is that the test should call SimpleTest.requestFlakyTimeout with a reason parameter, stating why it's necessary for this to use setTimeout with a non-zero timeout value.  See bug 649012's dependency list for some examples.  The function call should look something like:

SimpleTest.requestFlakyTimeout("This test should use timeouts because...");

Simple as that!  :-)

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

There we go, thanks for the explanation.

hg export'ed to make it easier in case you want to land this together with the SimpleTest patch from bug 649012.

I guess a rubberstamp for this is enough?

Comment 3

[(no longer active)]

Comment on attachment 528789 [details] [diff] [review]
Patch

(In reply to comment #2)
> There we go, thanks for the explanation.

Thanks for writing this patch.

> hg export'ed to make it easier in case you want to land this together with the
> SimpleTest patch from bug 649012.

Great.  Indeed, this needs to land with everything else in bug 649012.

> I guess a rubberstamp for this is enough?

It should be.  r=me to make it explciit.  :-)

Comment 4

[(no longer active)]

Landed with the wrong bug number: https://hg.mozilla.org/integration/mozilla-inbound/rev/ee4ee2b72573
Backed out: https://hg.mozilla.org/integration/mozilla-inbound/rev/47079c098699
Relanded: https://hg.mozilla.org/integration/mozilla-inbound/rev/7c3cd34ca884

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7c3cd34ca884