Closed Bug 652982 Opened 9 years ago Closed 6 years ago

[READY] test_close_on_last_window.xul needs to be explicit about its timeout requirements

Categories

(Toolkit :: Downloads API, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: ehsan, Assigned: Felipe)

References

Details

Attachments

(1 file)

See the discussion in bug 544356 comment 56 onwards.
Blocks: 544356
What should happen here is that the test should call SimpleTest.requestFlakyTimeout with a reason parameter, stating why it's necessary for this to use setTimeout with a non-zero timeout value.  See bug 649012's dependency list for some examples.  The function call should look something like:

SimpleTest.requestFlakyTimeout("This test should use timeouts because...");

Simple as that!  :-)
Attached patch PatchSplinter Review
There we go, thanks for the explanation.

hg export'ed to make it easier in case you want to land this together with the SimpleTest patch from bug 649012.

I guess a rubberstamp for this is enough?
Assignee: nobody → felipc
Status: NEW → ASSIGNED
Comment on attachment 528789 [details] [diff] [review]
Patch

(In reply to comment #2)
> There we go, thanks for the explanation.

Thanks for writing this patch.

> hg export'ed to make it easier in case you want to land this together with the
> SimpleTest patch from bug 649012.

Great.  Indeed, this needs to land with everything else in bug 649012.

> I guess a rubberstamp for this is enough?

It should be.  r=me to make it explciit.  :-)
Attachment #528789 - Flags: review+
Summary: test_close_on_last_window.xul needs to be explicit about its timeout requirements → [READY] test_close_on_last_window.xul needs to be explicit about its timeout requirements
https://hg.mozilla.org/mozilla-central/rev/7c3cd34ca884
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.