652988 - Passwords API should not throw nsIExceptions

Status: RESOLVED INCOMPLETE

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Will Bamberg [:wbamberg]]

See bug 646865 comment 5.

> High-level Jetpack APIs should not be exposing nsIFoos. 
> This should be a standard JavaScript Error object.

Comment 1

[Will Bamberg [:wbamberg]]

(In reply to comment #0)
> See bug 646865 comment 5.
> 

Or, preferably, bug 646865 comment 7.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

(automatic reprioritization of 1.0 bugs)

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(Pushing all open bugs to the --- milestone for the new triage system)

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Bug 646865 was fixed a few hours after comment 1 was made, back in April.

Will, is this still needed?

Comment 5

[Will Bamberg [:wbamberg]]

Hey Wes

Yes: or at least, it's not invalidated by bug 646865 being closed. 646865 was a docs bug; this bug came from an observation Drew made about the Passwords API: that it should not expose internal nsI* objects. FWIW I agree with this.

I suppose fixing it now is a compatibility break, so we might choose to WONTFIX it, and we have a lot of bugs that are more serious, but it does seem to me a valid bug still.

Comment 6

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1399562