Closed Bug 652988 Opened 9 years ago Closed 2 years ago

Passwords API should not throw nsIExceptions

Categories

(Add-on SDK Graveyard :: General, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: wbamberg, Unassigned)

References

Details

See bug 646865 comment 5.

> High-level Jetpack APIs should not be exposing nsIFoos. 
> This should be a standard JavaScript Error object.
(In reply to comment #0)
> See bug 646865 comment 5.
> 

Or, preferably, bug 646865 comment 7.
Priority: -- → P3
Target Milestone: --- → 1.0
(automatic reprioritization of 1.0 bugs)
Priority: P3 → P2
Target Milestone: 1.0 → 1.1
(Pushing all open bugs to the --- milestone for the new triage system)
Target Milestone: 1.1 → ---
Bug 646865 was fixed a few hours after comment 1 was made, back in April.

Will, is this still needed?
Hey Wes

Yes: or at least, it's not invalidated by bug 646865 being closed. 646865 was a docs bug; this bug came from an observation Drew made about the Passwords API: that it should not expose internal nsI* objects. FWIW I agree with this.

I suppose fixing it now is a compatibility break, so we might choose to WONTFIX it, and we have a lot of bugs that are more serious, but it does seem to me a valid bug still.
Assignee: nobody → erikvvold
Status: NEW → ASSIGNED
Assignee: erikvvold → evold
Assignee: evold → nobody
https://bugzilla.mozilla.org/show_bug.cgi?id=1399562
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.